v8.runtimestats.browsing_desktop failing on 14 builders |
|||||
Issue descriptionstats->current_timer_.Value() == timer check failure when collecting RuntimeCallStatistics Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Mac 10.11 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf - Mac 10.12 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf - Mac Air 10.11 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Air%2010.11%20Perf - Mac Pro 10.11 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Pro%2010.11%20Perf - Mac Retina Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf - Win 10 High-DPI Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf - Win 10 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf - Win 7 ATI GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf - Win 7 Intel GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf - Win 7 Nvidia GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf - Win 7 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf - Win 7 x64 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf - Win 8 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf The reddit story is failing. Seems to be crashing on all desktop platforms, I'll disable it.
,
Sep 1 2017
Thanks for disabling the story. I will take a look into the crash.
,
Sep 1 2017
It crashes at the following check: # Fatal error in ../../v8/src/counters.cc, line 488 # Check failed: stats->current_timer_.Value() == timer. I think this could be because of a recent change: https://chromium-review.googlesource.com/637307. alph@ could you please take a look to see if it is related.
,
Sep 1 2017
Issue 759797 has been merged into this issue.
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25bf3c3c10a94f304e44e0d432e0936c56891750 commit 25bf3c3c10a94f304e44e0d432e0936c56891750 Author: Stephen Martinis <martiniss@chromium.org> Date: Fri Sep 01 21:00:10 2017 //tools/perf: Disable reddit story for v8 browsing TBR=rnephew Bug: 759777 Change-Id: If719173a9fc587e458f2b8791be05449ac1e3bd5 Reviewed-on: https://chromium-review.googlesource.com/639035 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#499292} [modify] https://crrev.com/25bf3c3c10a94f304e44e0d432e0936c56891750/tools/perf/page_sets/system_health/expectations.py
,
Sep 22 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1935e6f272f50e5d37a3758072610e57dd73dc28 commit 1935e6f272f50e5d37a3758072610e57dd73dc28 Author: Mythri Alle <mythria@chromium.org> Date: Fri Sep 22 11:53:05 2017 tools/perf: Disable cnn story on V8 browsing benchmark. Bug: chromium:767595 , chromium:759777 Change-Id: I743f0af0e3c9191b3bc76036c06361c56a864573 Reviewed-on: https://chromium-review.googlesource.com/678716 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#503716} [modify] https://crrev.com/1935e6f272f50e5d37a3758072610e57dd73dc28/tools/perf/page_sets/system_health/expectations.py
,
Sep 22 2017
The patch in comment #3 has been landed on Aug 29, but the failure and bug report is dated Aug 28. I this the patch that caused the crash is in fact this one (landed on Aug 25): https://chromium-review.googlesource.com/c/v8/v8/+/634511 but it had been reverted right after you recorder the crash. So I suggest you to reenable the test and check if they are passing.
,
Sep 26 2017
There are more recent failures on the same check on cnn page. For example this: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf/builds/265.
,
Sep 26 2017
Issue 767595 has been merged into this issue.
,
Oct 5 2017
Issue 770920 has been merged into this issue.
,
Oct 5 2017
I checked these pages locally. Reddit is not failing anymore. CNN is still failing with the latest version. TOI does not seem to fail locally too. I tried it 3 times and it did not fail. May be it is flaky on TOI. I will look a bit into CNN and update the bug if I find anything.
,
Oct 6 2017
I looked into CNN a bit more. It fails because stats->current_timer_.Value() is null and timer points to a non null value (API_ScriptCompiler_Compile in the case of CNN). If I understand correctly, we have a different RuntimeCallStats for each background task and the tasks on main thread use a different counter. I think somewhere, we are using the RuntimeCallStats on the wrong thread and hence we are seeing this problem?
,
Oct 6 2017
alph@ has been chasing after the last stray counters I think. You're probably right, we must be using the RuntimeCallTimerScope with the constructor which takes the isolate (which in turn uses the shared stats_table). We should probably add a DCHECK there to make sure you don't end up using the wrong constructor.
,
Oct 6 2017
Some more digging into it. The current thread id does not match with the stats->thread_id() for GetMoreDataCallback. Which is related to fetching data in the parser. Surprisingly it still fails even when I pass --single-threaded to V8. In my understanding it should disable any background processing.
,
Oct 6 2017
Yes, it is likely caused by several threads trying to modify the counters stack. There's another issue about that. Let me close this one as a duplicate.
,
Oct 13 2017
Issue 763070 has been merged into this issue.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc8ff77a65c695c5829c9bcb13a4a23f50bcd62f commit bc8ff77a65c695c5829c9bcb13a4a23f50bcd62f Author: Mythri Alle <mythria@chromium.org> Date: Wed Nov 08 11:00:55 2017 Enable stories in v8.runtimestats* benchmark Enable stories in v8.runtimestats benchmark that were disabled due to a bug in RCS. Bug: chromium:759777 Change-Id: Ie37bff440ddd39744f18b2c935c1cc88851f115d Reviewed-on: https://chromium-review.googlesource.com/757436 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#514793} [modify] https://crrev.com/bc8ff77a65c695c5829c9bcb13a4a23f50bcd62f/tools/perf/benchmarks/v8_browsing.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by martiniss@chromium.org
, Sep 1 2017Owner: mythria@chromium.org
Status: Assigned (was: Available)