Remove full-screen launcher UMA bias |
|||||||
Issue descriptionFull-screen launcher can be turned on via variations or via a flag. Turning via a flag is done in a way that causes incorrect reporting for metrics. Same for blur. Need to fix it to get accurate metrics.
,
Aug 28 2017
Approving merge to M61.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1515d7e5635f36ea707b22e799ef0673763611de commit 1515d7e5635f36ea707b22e799ef0673763611de Author: Vadim Tryshev <vadimt@google.com> Date: Tue Aug 29 00:46:09 2017 Using canonical way to enable launcher features flags. This is variations-team-recommended way, and it avoids incorrectly counting stats from clients disabled via variations but enabled via flag from being counted as coming from disabled clients. Bug: 759769 Change-Id: I4a6f1fdf11a6954deb42d0d98f4fdcd01cc375ee Reviewed-on: https://chromium-review.googlesource.com/639034 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#497961} [modify] https://crrev.com/1515d7e5635f36ea707b22e799ef0673763611de/chrome/browser/about_flags.cc [modify] https://crrev.com/1515d7e5635f36ea707b22e799ef0673763611de/tools/metrics/histograms/enums.xml [modify] https://crrev.com/1515d7e5635f36ea707b22e799ef0673763611de/ui/app_list/app_list_features.cc [modify] https://crrev.com/1515d7e5635f36ea707b22e799ef0673763611de/ui/app_list/app_list_switches.cc [modify] https://crrev.com/1515d7e5635f36ea707b22e799ef0673763611de/ui/app_list/app_list_switches.h
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fff3198694129fbf3e8037424194d201a1a2fd3d commit fff3198694129fbf3e8037424194d201a1a2fd3d Author: Vadim Tryshev <vadimt@google.com> Date: Tue Aug 29 18:21:17 2017 Using canonical way to enable launcher features flags. This is variations-team-recommended way, and it avoids incorrectly counting stats from clients disabled via variations but enabled via flag from being counted as coming from disabled clients. TBR=vadimt@google.com (cherry picked from commit 1515d7e5635f36ea707b22e799ef0673763611de) Bug: 759769 Change-Id: I4a6f1fdf11a6954deb42d0d98f4fdcd01cc375ee Reviewed-on: https://chromium-review.googlesource.com/639034 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#497961} Reviewed-on: https://chromium-review.googlesource.com/641991 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#976} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/fff3198694129fbf3e8037424194d201a1a2fd3d/chrome/browser/about_flags.cc [modify] https://crrev.com/fff3198694129fbf3e8037424194d201a1a2fd3d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/fff3198694129fbf3e8037424194d201a1a2fd3d/ui/app_list/app_list_features.cc [modify] https://crrev.com/fff3198694129fbf3e8037424194d201a1a2fd3d/ui/app_list/app_list_switches.cc [modify] https://crrev.com/fff3198694129fbf3e8037424194d201a1a2fd3d/ui/app_list/app_list_switches.h
,
Aug 29 2017
,
Sep 4 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 5 2017
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Aug 28 2017