Add Chrome IPC unit-tests for Attachments which will rely on native handles under Fuchsia. |
||||
Issue descriptionWe got Chrome IPC unit-tests working, but when bringing up Headless Shell we still needed these fixes: https://chromium-review.googlesource.com/c/chromium/src/+/636783 It looks like the Chrome IPC unit-tests don't include any cases which would involve passing native Fuchsia handles across IPC (e.g. SharedMemory?), only file-descriptor handles. We should add some simple tests for this case.
,
Aug 28 2017
,
Aug 29 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/831ae413be48d9df751ea9591e50088c348e8ded commit 831ae413be48d9df751ea9591e50088c348e8ded Author: Wez <wez@chromium.org> Date: Wed Aug 30 00:29:36 2017 Add unit-test for passing base::SharedMemory via Chrome IPC. This test verifies, on all platforms[1], that base::SharedMemory instances can be transferred via Chrome IPC. Existing tests verified only that platform-specific handle types could be transferred, without verifying that the IPC::Channel Mojo implementation can correctly handle all of each platform's handle type(s). Also cleans up use of deprecated QuitCurrent method on RunLoop. [1] Since base::SharedMemory on Mac uses Mach ports, which require that we set up a MachPortBroker to transfer across IPC, we don't test on Mac for now. Bug: 759760 Change-Id: I818107b21b7f59712b0cf3e157d3140fee67e9f8 Reviewed-on: https://chromium-review.googlesource.com/640190 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#498304} [modify] https://crrev.com/831ae413be48d9df751ea9591e50088c348e8ded/ipc/ipc_channel_mojo_unittest.cc
,
Aug 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted