Direct-leak in snd_midi_event_new |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6602288012722176 Fuzzer: inferno_layout_test_unmodified Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Direct-leak Crash Address: Crash State: snd_midi_event_new snd_midi_event_new Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=487800:487821 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6602288012722176 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Aug 29 2017
,
Aug 29 2017
cc: agoode if you have time.
,
Aug 29 2017
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7fa217d030fa in __interceptor_calloc (/mnt/scratch0/clusterfuzz/slave-bot/builds/chromium-browser-asan_linux-release_4392242b7f59878a2775b4607420a2b37e17ff13/symbolized/release/asan-linux-release-497686/chrome+0x31f70fa)
#1 0x7fa20f00865f in snd_midi_event_new (/usr/lib/x86_64-linux-gnu/libasound.so.2+0x9d65f)
Indirect leak of 256 byte(s) in 1 object(s) allocated from:
#0 0x7fa217d02f03 in __interceptor_malloc (/mnt/scratch0/clusterfuzz/slave-bot/builds/chromium-browser-asan_linux-release_4392242b7f59878a2775b4607420a2b37e17ff13/symbolized/release/asan-linux-release-497686/chrome+0x31f6f03)
#1 0x7fa20f008697 in snd_midi_event_new (/usr/lib/x86_64-linux-gnu/libasound.so.2+0x9d697)
256 bytes indicates this will be one at line 860, that uses kSendBufferSize.
There is a 'return' path there, and probably it would be better to use ScopedSndMidiEvent?
,
Aug 30 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c0059c250e3b6c3114566c64397ef37ca961a60 commit 0c0059c250e3b6c3114566c64397ef37ca961a60 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Fri Sep 01 04:59:51 2017 MidiManagerAlsa: memory leak fix of snd_midi_event_t There was an error path that caused memory leaks of snd_midi_event_t. This patch enforces all code path to use ScopedSndMidiEventPtr. Bug: 759756 Change-Id: Icc2f85fccc66ad9714af18ed5bd90c7f009f4dbb Reviewed-on: https://chromium-review.googlesource.com/643030 Reviewed-by: Adam Goode <agoode@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#499133} [modify] https://crrev.com/0c0059c250e3b6c3114566c64397ef37ca961a60/media/midi/midi_manager_alsa.cc [modify] https://crrev.com/0c0059c250e3b6c3114566c64397ef37ca961a60/media/midi/midi_manager_alsa.h
,
Sep 1 2017
,
Sep 2 2017
ClusterFuzz has detected this issue as fixed in range 499123:499135. Detailed report: https://clusterfuzz.com/testcase?key=6602288012722176 Fuzzer: inferno_layout_test_unmodified Job Type: linux_lsan_chrome_mp Platform Id: linux Crash Type: Direct-leak Crash Address: Crash State: snd_midi_event_new snd_midi_event_new Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=487800:487821 Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=499123:499135 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6602288012722176 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Sep 2 2017
ClusterFuzz testcase 6602288012722176 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Aug 29 2017Status: Assigned (was: Untriaged)