New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759745 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] waterfall_config_test.testGetCheckFlakeSettings fails on buildbot.

Project Member Reported by wylieb@chromium.org, Aug 28 2017

Issue description

Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra%2Finfra-continuous-trusty-64%2F8659%2F%2B%2Frecipes%2Fsteps%2Finfra_python_tests%2F0%2Fstdout

Many entries that the buildbots are using for the config don't match the config we use for local unit tests.

- {'minimum_confidence_score_to_run_tryjobs': 0.6,
+ {u'minimum_confidence_score_to_run_tryjobs': 0.6,
?  +
-  'swarming_rerun': {'data_point_sample_size': 5,
+  u'swarming_rerun': {u'data_point_sample_size': 5,
?  +                   +
-                     'dive_rate_threshold': 0.4,
+                      u'dive_rate_threshold': 0.4,
?                     ++
-                     'iterations_to_rerun': 100,
+                      u'iterations_to_rerun': 100,
?                     ++
+                      u'lower_flake_threshold': 0.02,
+                      u'max_build_numbers_to_look_back': 1000,
+                      u'max_dive_in_a_row': 4,
+                      u'max_flake_in_a_row': 4,
+                      u'max_iterations_to_rerun': 800,
+                      u'max_stable_in_a_row': 4,
+                      u'timeout_cushion_multiplier': 1,
+                      u'timeout_per_swarming_task_seconds': 3600,
+                      u'timeout_per_test_seconds': 120,
+                      u'upper_flake_threshold': 0.98,
+                      u'use_nearby_neighbor': True},
+  u'try_job_rerun': {u'iterations_to_rerun': 100,
-                     'lower_flake_threshold': 0.02,
+                     u'lower_flake_threshold': 0.02,
?                     +
-                     'max_build_numbers_to_look_back': 1000,
-                     'max_dive_in_a_row': 4,
-                     'max_flake_in_a_row': 4,
?                                           ^
+                     u'max_flake_in_a_row': 1,
?                     +                      ^
-                     'max_iterations_to_rerun': 800,
-                     'max_stable_in_a_row': 4,
?                                            ^
+                     u'max_stable_in_a_row': 0,
?                     +                       ^
-                     'timeout_per_swarming_task_seconds': 3600,
-                     'timeout_per_test_seconds': 120,
-                     'upper_flake_threshold': 0.98,
+                     u'upper_flake_threshold': 0.98},
?                     +                             +
-                     'use_nearby_neighbor': True},
-  'try_job_rerun': {'iterations_to_rerun': 100,
-                    'lower_flake_threshold': 0.02,
-                    'max_flake_in_a_row': 1,
-                    'max_stable_in_a_row': 0,
-                    'upper_flake_threshold': 0.98},
-  'update_monorail_bug': False}
+  u'update_monorail_bug': False}
?  +
 

Comment 1 by st...@chromium.org, Aug 28 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fdb4c44fa379ba11dca724ffd1b35be5897410a1

commit fdb4c44fa379ba11dca724ffd1b35be5897410a1
Author: Brandon Wylie <wylieb@chromium.org>
Date: Mon Aug 28 19:31:39 2017

[Findit] Removing timeout_cushion_multiplier from config.

Bug:759745
Change-Id: Ide073177eea3fdb37462f80f5d702ab3dd0acf9a
Reviewed-on: https://chromium-review.googlesource.com/638921
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/analyze_flake_for_build_number_pipeline_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/waterfall_config.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/finish_build_analysis_pipeline_test.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/flake_analysis_util.py
[modify] https://crrev.com/fdb4c44fa379ba11dca724ffd1b35be5897410a1/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py

Comment 3 by wylieb@chromium.org, Sep 11 2017

Status: Verified (was: Assigned)

Sign in to add a comment