New issue
Advanced search Search tips

Issue 759741 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

apk install script out of date and won't rebuild for monochrome

Project Member Reported by estevenson@chromium.org, Aug 28 2017 
To reproduce:

$ ninja -C out/Debug monochrome_public_apk
$ out/Debug/bin/monochrome_public_apk install
Script out-of-date. Rebuild via:
  ninja -C out/Debug bin/monochrome_public_apk

Rebuilding the script doesn't fix the issue. The above steps work fine for chrome_public_apk. Am I holding it wrong?

Comment 1 by estevenson@chromium.org, Aug 28 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39e4016d4786d678f9d73be40626709e047f60e1

commit 39e4016d4786d678f9d73be40626709e047f60e1
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Aug 28 19:39:25 2017

Android: Fix monochrome_apk wrapper script os.path.exists(None)

Bug:  759741 
Change-Id: I1bd9fcfa51ac6a04941db6a6c762b5a4ecf9c8c0
Reviewed-on: https://chromium-review.googlesource.com/638442
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497844}
[modify] https://crrev.com/39e4016d4786d678f9d73be40626709e047f60e1/build/android/apk_operations.py

Comment 3 by dtrainor@chromium.org, Feb 8 2018

Status: Fixed (was: Untriaged)
agrieve@ marking this as fixed.  Looks like you addressed it with that patch.  Feel free to reopen if it is not thanks!
►

Sign in to add a comment