New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759732 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

http/tests/devtools/console/console-format.html failing

Project Member Reported by tbansal@chromium.org, Aug 28 2017

Issue description

Cc: chenwilliam@chromium.org l...@chromium.org
Components: Platform>DevTools
Rebaselining in progress.
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by l...@chromium.org, Aug 28 2017

Cc: -l...@chromium.org
Thanks for the report.  For context and reference:

1) console-format.html used to be skipped with NeedsManualRebaseline

2) A V8 change autoroll landed that leads to changes in console-format.html's expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/636395

3) The NeedsManualRebaseline is safely removed
https://chromium-review.googlesource.com/c/chromium/src/+/618568

4) A recent revert of the V8 undoes change #2 and leads to failures:
https://chromium.googlesource.com/chromium/src/+/edaae4a4e30b7e6f0174a4edfa0ac6d27625f8c3

5) console-format.html is skipped/re-added to TestExpectations in another CL
https://chromium.googlesource.com/chromium/src/+/3fb9fd31d5f4384271ae0ace68b80185829b8cc5%5E%21/#F0

The plan now, is to wait until the V8 autoroller rerolls the changes in #2, wait a longer amount of time to be safe, and then remove the test from TestExpectations again.  I don't know how common this scenario is, but as far as I can tell, there's no way to tell others which tests will fail if a V8 autoroll is reverted.
OK, until then I am going to add NeedsManualRebaseline in the test expectations.

Comment 7 by l...@chromium.org, Aug 28 2017

Ahh ok.  I thought leaving it as [Failure Pass] was enough, but NMR is more accurate.  Thank you tbansal@.
Sorry, I did not see that the expectation was updated to [Failure Pass]. I will leave it as such.

Comment 9 by l...@chromium.org, Nov 8 2017

Status: WontFix (was: Assigned)
No worries.  Since the TestExpectations line is already marked with the appropriate crbug, I will close this one.

Sign in to add a comment