New issue
Advanced search Search tips

Issue 759704 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInJsFullscreen is flaky on Linux

Project Member Reported by tbansal@chromium.org, Aug 28 2017

Issue description

Is this test flaky only in browser_side_navigation_interactive_ui_tests?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a50d2ad4ba32f96d593946ba8f11d8c0491106

commit e6a50d2ad4ba32f96d593946ba8f11d8c0491106
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Aug 28 17:15:03 2017

Disable ShortcutsShouldTakeEffectInJsFullscreen on Linux

This test is flaky on Linux. Refer to the bug for details.

NOTRY=true

Bug: 759704
TBR: msw@chromium.org
Change-Id: Ie408bf23d95cf9fd983f375dc3ac9b217ffd9ba5
Reviewed-on: https://chromium-review.googlesource.com/638314
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497783}
[modify] https://crrev.com/e6a50d2ad4ba32f96d593946ba8f11d8c0491106/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc

Yes.
Then maybe some assumptions have been broken, e.g. some actions may be not synchronous in browser_side_navigation_interactive_ui_tests.

Thank you for taking care of the flakiness. I will work with guys who are working on browser-side navigation to investigate the root cause.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729922fb081afb7f1066846cceeb08ef2a6ab8d8

commit 729922fb081afb7f1066846cceeb08ef2a6ab8d8
Author: Zijie He <zijiehe@chromium.org>
Date: Tue Aug 29 23:59:32 2017

Only disable ShortcutsShouldTakeEffectInJsFullscreen when IsBrowserSideNavigationEnabled()

So far this test is only flaky on Linux when IsBrowserSideNavigationEnabled(),
we should not disable it entirely on Linux. So this change partially enables the
test to track its flakiness when browser-side navigation is disabled.

Bug: chromium:759704
Change-Id: I92df09deacf72b3f7d4cafa45549ac26f333c938
Reviewed-on: https://chromium-review.googlesource.com/641074
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498292}
[modify] https://crrev.com/729922fb081afb7f1066846cceeb08ef2a6ab8d8/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc

Owner: ----
Status: Available (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled
Labels: Hotlist-DisableReview

Sign in to add a comment