BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInJsFullscreen is flaky on Linux |
|||||
Issue description
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a50d2ad4ba32f96d593946ba8f11d8c0491106 commit e6a50d2ad4ba32f96d593946ba8f11d8c0491106 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Aug 28 17:15:03 2017 Disable ShortcutsShouldTakeEffectInJsFullscreen on Linux This test is flaky on Linux. Refer to the bug for details. NOTRY=true Bug: 759704 TBR: msw@chromium.org Change-Id: Ie408bf23d95cf9fd983f375dc3ac9b217ffd9ba5 Reviewed-on: https://chromium-review.googlesource.com/638314 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#497783} [modify] https://crrev.com/e6a50d2ad4ba32f96d593946ba8f11d8c0491106/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc
,
Aug 28 2017
Yes.
,
Aug 28 2017
Then maybe some assumptions have been broken, e.g. some actions may be not synchronous in browser_side_navigation_interactive_ui_tests. Thank you for taking care of the flakiness. I will work with guys who are working on browser-side navigation to investigate the root cause.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/729922fb081afb7f1066846cceeb08ef2a6ab8d8 commit 729922fb081afb7f1066846cceeb08ef2a6ab8d8 Author: Zijie He <zijiehe@chromium.org> Date: Tue Aug 29 23:59:32 2017 Only disable ShortcutsShouldTakeEffectInJsFullscreen when IsBrowserSideNavigationEnabled() So far this test is only flaky on Linux when IsBrowserSideNavigationEnabled(), we should not disable it entirely on Linux. So this change partially enables the test to track its flakiness when browser-side navigation is disabled. Bug: chromium:759704 Change-Id: I92df09deacf72b3f7d4cafa45549ac26f333c938 Reviewed-on: https://chromium-review.googlesource.com/641074 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#498292} [modify] https://crrev.com/729922fb081afb7f1066846cceeb08ef2a6ab8d8/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc
,
Dec 11 2017
,
Jan 24 2018
,
Jan 24 2018
,
Mar 20 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by zijiehe@chromium.org
, Aug 28 2017