New issue
Advanced search Search tips

Issue 759691 link

Starred by 2 users

Issue metadata

Status: Closed
Owner:
Closed: Jan 19
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 882906
issue 754861



Sign in to add a comment

BackgroundSyncManagerTest.DeleteAndStartOverServiceWorkerContext fails in content_unittests on Fuchsia due to stat/lstat misbehaviour

Project Member Reported by scottmg@chromium.org, Aug 28 2017

Issue description

BackgroundSyncManagerTest.DeleteAndStartOverServiceWorkerContext fails on a DeleteFile call to remove a database file, where the filename is empty.

base/ tests for this by using lstat http://pubs.opengroup.org/onlinepubs/009695399/functions/lstat.html

which specifically calls out 

"""
[ENOENT]
A component of path does not name an existing file or path is an empty string.
"""

however, Fuchsia sets errno to EINVAL, not ENOENT for an empty path.

I will file upstream for this.
 
MG-1062 upstream.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bab7b56965a498c7b0f8d36a5e309b3a320278f

commit 8bab7b56965a498c7b0f8d36a5e309b3a320278f
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Aug 28 17:47:07 2017

fuchsia: Triage BackgroundSyncManagerTest in content_unittests

Just shuffling .filter file around to tag with associated bug.

Bug:  759691 
Change-Id: I30cfa1b739b161d1dc9a5ef244e7ecfba1b113bb
TBR: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/638771
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497793}
[modify] https://crrev.com/8bab7b56965a498c7b0f8d36a5e309b3a320278f/testing/buildbot/filters/fuchsia.content_unittests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef73ab2177944c52638880c80efa38deddf8ea47

commit ef73ab2177944c52638880c80efa38deddf8ea47
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Aug 29 00:09:54 2017

fuchsia: More content_unittests filter triage

Bug: 759853,  759691 
Change-Id: I927f05b5d04fd2bb99aa5bcde46771257a84fe26
Reviewed-on: https://chromium-review.googlesource.com/639339
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497951}
[modify] https://crrev.com/ef73ab2177944c52638880c80efa38deddf8ea47/testing/buildbot/filters/fuchsia.content_unittests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/128a2e5f55ec007db4ed9cc48d1e2b4738a914a9

commit 128a2e5f55ec007db4ed9cc48d1e2b4738a914a9
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Sep 11 23:55:30 2017

fuchsia: Enable tests that required empty filename lstat()

Fixed by upstream MG-1062.

Bug:  759691 
Change-Id: Id4155b1e4a223ead110dad3059676816280c1418
Reviewed-on: https://chromium-review.googlesource.com/661558
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501101}
[modify] https://crrev.com/128a2e5f55ec007db4ed9cc48d1e2b4738a914a9/testing/buildbot/filters/fuchsia.content_unittests.filter

Blocking: 882906

Comment 6 by w...@chromium.org, Jan 19 (3 days ago)

Status: Closed (was: ExternalDependency)

Sign in to add a comment