New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759646 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

<webview> webRequest sendMessage only works with the first webview

Project Member Reported by jam@chromium.org, Aug 28 2017

Issue description

Pavol pointed out that there's a typo

event_filtering_info.instance_id = is_web_view_guest;

(https://cs.chromium.org/chromium/src/extensions/browser/api/web_request/web_request_api.cc?rcl=7b4b0d1feadff5ac989f0a73f190a35c08cc0a07&l=306)

I added this in r425699.

This would prevent sendmessage from reaching all webviews other than the first one that's created.
 

Comment 1 by jam@chromium.org, Aug 28 2017

Description: Show this description

Comment 2 by jam@chromium.org, Aug 28 2017

Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df29e5e27a26e82a9a984a23c1e87cc5352f539f

commit df29e5e27a26e82a9a984a23c1e87cc5352f539f
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Aug 28 18:59:21 2017

Fix typo with <webview> WebRequest API that was introduced in r425699.

Thanks to pmarko@ for pointing this out.

BUG= 504347 

Change-Id: I60c81a1c5f34b023304f106940a04dd1d887a6c8
Reviewed-on: https://chromium-review.googlesource.com/638413
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497819}
[modify] https://crrev.com/df29e5e27a26e82a9a984a23c1e87cc5352f539f/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/df29e5e27a26e82a9a984a23c1e87cc5352f539f/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
[modify] https://crrev.com/df29e5e27a26e82a9a984a23c1e87cc5352f539f/extensions/browser/api/web_request/web_request_api.cc

Sign in to add a comment