Just had another instance of this: https://chromium-review.googlesource.com/c/v8/v8/+/634906

And is another one: https://chromium-review.googlesource.com/c/v8/v8/+/636762

This has been failing now for roughly a week and is rather dangerous, as people are expecting the revert to land automatically without further interaction usually.

According to your own label description is a P1.
I'll bluntly assign it to one of the suggested component owners.

The code that fails is in CQ plugin, although it might be caused by recent PG release. Anyway, this should be assigned to agable@ (who is back to work today) and moved to Chromium tracker, but I can't do that.

Moved issue gerrit:7072 to now be  issue chromium:759629 .

I'm only temporarily back today; I have another whole week of vacation after today. Andrii, please dig into this since it is Pri-1.

The code which sets the Code-Review label (and the Commit-Queue label, if the revert is made within 24 hours of the original landing) is here: http://shortn/_vvGm68nq61

This code hasn't changed in a long time, and simply returns a set of labels which should be applied to a Gerrit API function. So it looks like that Gerrit JS API changed and broke? Viktar, can you comment on that?

 Issue gerrit:7075  has been merged into this issue.

Note wyatta@'s comment in https://bugs.chromium.org/p/gerrit/issues/detail?id=7075 :

This may be related to   Issue gerrit:6969  , where the revert change is sometimes not immediately available after the revert action completes. However, since the error comes from commitqueue.js, I suspect this is separate from 6969 -- but with possibly the same underlying cause.

Locally I see errors when reverting even with the commitqueue.js plugin switched off.
In the console I see:

gr-auth.js:116 GET http://rmistry1.cnc.corp.google.com:8080/changes/demo-project2~76/revisions/6/files?reviewed 404 ()
_fetchWithXsrfToken @ gr-auth.js:116
fetch @ gr-auth.js:81
_fetchRawJSON @ gr-rest-api-interface.js:107
fetchJSON @ gr-rest-api-interface.js:145
_changeBaseURL.then.url @ gr-rest-api-interface.js:1817
gr-auth.js:116 GET http://rmistry1.cnc.corp.google.com:8080/changes/demo-project2~76/revisions/6/commit?links 404 ()
_fetchWithXsrfToken @ gr-auth.js:116
fetch @ gr-auth.js:81
_fetchRawJSON @ gr-rest-api-interface.js:107
fetchJSON @ gr-rest-api-interface.js:145
_changeBaseURL.then.url @ gr-rest-api-interface.js:1817
3gr-error-manager.js:103 Not found: 6


[Note the revisions/6 in the error above]


This is why I thought it was a Gerrit issue ( Issue gerrit:7075 ) and not a Chromium plugin one.
Every time I revert locally I see the files list and patchset drop downs empty. When I refresh, they are populated again.
I also think that it works only if the change you are reverting has a single patch set.

Gerrit folks, can you please try it out locally to see if you can reproduce the empty files list / patchset during reverts (please make sure that the change that is being reverted has more than 1 patchset)

> Gerrit folks, can you please try it out locally to see if you can reproduce the empty files list / patchset during reverts (please make sure that the change that is being reverted has more than 1 patchset)

I can repro. Thank you! Reverting a change with multiple patch sets looks like the key repro step. This looks like a bug in PolyGerrit, although I'm not sure if it's the cause of the buildbot- issue in 7075 or the CQ issue in this one (although it might be).

I'll reopen  issue 6969  for the PolyGerrit fix.

[Note: wyatta@ meant  Issue gerrit:6969  in the previous comment]

Yes, I am not 100% sure either. Once we have a PolyGerrit fix I will test out commitqueue.js locally.

sorry, I won't be able to look at this week, assigning to wyatta@ because he has a clue now. Ravi, thanks for help, too :)

This is showing up more (e.g. https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/654117); please prioritize

The fix for  Issue gerrit:6969  has merged and should deploy soon.

Once that's live on Chromium I'd like to confirm that fixing the Gerrit part transitively fixes the CQ part.

tandrii@ or agable@, the Gerrit fix is live on chromium-reviww. Can you confirm that this resolves the issue in CQ?

Yes, it worked correctly for me just now:
https://chromium-review.googlesource.com/c/chromium/src/+/671524