New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759617 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Symbolized stdout should retain unsymbolized log

Project Member Reported by jbudorick@chromium.org, Aug 28 2017

Issue description

Seeing several cases where the only failure log for instrumentation test failures is the output from the stack script:

Searching for native crashes in: /b/swarming/w/itxzeCQ7/tmpUVyi4Q
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/swarming/w/ir
Searching for Chrome symbols from within: /b/swarming/w/ir/out/Release/lib.unstripped:/b/swarming/w/ir/out/Release/lib:/b/swarming/w/ir/out/Release

https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/45235

We should try just appending the symbolized output to the unsymbolized stack.
 

Comment 1 by hzl@chromium.org, Aug 28 2017

It would be an easy change. I will add the unsymbolized stack.

I suspect that the reason that no symbolized output is printed out is that there is no 'stack'. It is a failure not a crash. What do you think?
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f224fff0b36b75e9e67ec4a800f88a314f8cb476

commit f224fff0b36b75e9e67ec4a800f88a314f8cb476
Author: Zhiling Huang <hzl@chromium.org>
Date: Mon Aug 28 21:04:56 2017

Print out unsymbolized stack together with symbolized stack.

Previously we only printed out symbolized stack, which may cause
information to be lost (those that cannot be symbolized in the log will
not appear in symbolized stack).

In this cl, I print out unsymbolized stack first, then symbolized stack,
to make sure no info is lost.

Bug:  759617 
Change-Id: I65c7406ac233a2aac4d28fd10359f91cf56375c0
Reviewed-on: https://chromium-review.googlesource.com/638859
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497872}
[modify] https://crrev.com/f224fff0b36b75e9e67ec4a800f88a314f8cb476/build/android/pylib/instrumentation/instrumentation_test_instance.py

Status: Fixed (was: Assigned)

Sign in to add a comment