New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759584 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

ForceBrowserSignin escape (II)

Project Member Reported by tnagel@chromium.org, Aug 28 2017

Issue description

Chrome Version: ToT
OS: Linux

What steps will reproduce the problem?
(1) Disable ForceBrowserSignin
(2) Start browser with a fresh user data dir
(3) Create two profiles, sign into one of them but keep the other signed-out
(4) Close browser while both profiles are open
(5) Enable ForceBrowserSignin
(6) Start browser

What is the expected result?
I guess this is a product question: Either only the signed-in profile should be opened or none at all.

What happens instead?
Both profiles are opened, one of which allows browsing the web without being signed in.
 

Comment 1 by zmin@chromium.org, Aug 28 2017

If there're two profiles. Only the signed in one could be used.

What does "Close browser while both profiles are open" mean?

Force-sign-in policy does not support dynamic refresh. It means Chrome needs to be fully restart after changing the policy value.

Comment 2 by tnagel@chromium.org, Aug 29 2017

> What does "Close browser while both profiles are open" mean?

It means closing the browser (Ctrl-Shift-Q) while there are two windows open, one for each profile.

> If there're two profiles. Only the signed in one could be used.

This does not match what I have observed.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9990e87e486cceef3914bcbb82979190315bad3a

commit 9990e87e486cceef3914bcbb82979190315bad3a
Author: Owen Min <zmin@chromium.org>
Date: Thu Oct 12 19:57:49 2017

Check |last_open_profiles| lock stataus during startup.

Only open the profiles in |last_open_profiles| that are not locked.
Show UserManager if all profiles are locked.

Bug:  759584 
Change-Id: Idae015b88e8280e877143ba6a7eab5930acc4d4d
Reviewed-on: https://chromium-review.googlesource.com/705822
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508404}
[modify] https://crrev.com/9990e87e486cceef3914bcbb82979190315bad3a/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/9990e87e486cceef3914bcbb82979190315bad3a/chrome/browser/ui/startup/startup_browser_creator.h
[modify] https://crrev.com/9990e87e486cceef3914bcbb82979190315bad3a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Comment 4 by zmin@chromium.org, Nov 7 2017

Status: Fixed (was: Assigned)

Sign in to add a comment