New issue
Advanced search Search tips

Issue 759575 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR

Blocked on:
issue 762018



Sign in to add a comment

VR: Remove workaround for crash after backing out of DON flow

Project Member Reported by mthiesse@chromium.org, Aug 28 2017

Issue description

See  issue 754342 . This is waiting on the fix for b/64899104 to roll out to the gvr SDK.
 
Labels: -M-62 M-63
Don't think this will make it into M-62.

Comment 2 by bshe@chromium.org, Sep 5 2017

Blockedon: 762018
Issue 768035 has been merged into this issue.
Labels: -M-63 M-64
Gvr push is happening too late in the cycle to risk a deps roll, moving this out to M-64
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c47c5d41409e64894ab3b178f261a38eef6a49c

commit 4c47c5d41409e64894ab3b178f261a38eef6a49c
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Nov 17 17:58:18 2017

Remove workaround for GVR crash when backing out of DON flow.

The GVR crash has been fixed, so we can remove our workaround (which
was to wait 10 seconds before allowing re-entry into VR)

The workaround was added in
https://chromium-review.googlesource.com/c/chromium/src/+/624294

Bug:  759575 
Change-Id: Iad46c0575d15c1eb7d67d46253eea50294243ae8
Reviewed-on: https://chromium-review.googlesource.com/776620
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517464}
[modify] https://crrev.com/4c47c5d41409e64894ab3b178f261a38eef6a49c/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: ExternalDependency)
Components: Internals>XR

Sign in to add a comment