New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759561 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

48.3% regression in smoothness.top_25_smooth at 497406:497502

Project Member Reported by kraynov@chromium.org, Aug 28 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 28 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=759561

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b630cdbe50e82700c3673799606a49f0e027227552ade7a9eecb2a8099c3b97d


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 28 2017

Cc: hejq@google.com
Owner: hejq@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author hejq@google.com ===

Hi hejq@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Jiaquan He
  Commit : 3cfbef66aba08e14528f202298ccc4df38c0eafe
  Date   : Fri Aug 25 19:43:01 2017
  Subject: Center the searchbox placeholder.

Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : percentage_smooth/https___plus.google.com_110031535020051778989_posts
  Change       : 4.34% | 65.3258911675 -> 62.48880681

Revision             Result                  N
chromium@497405      65.3259 +- 12.1392      21      good
chromium@497454      62.0217 +- 18.1981      14      good
chromium@497479      56.1137 +- 6.2114       6       good
chromium@497491      54.645 +- 3.89496       6       good
chromium@497497      53.3565 +- 5.99867      6       good
chromium@497500      54.5631 +- 3.52987      6       good
chromium@497501      53.8601 +- 5.11892      6       good
chromium@497502      62.4888 +- 9.01619      14      bad       <--

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...plus.google.com.110031535020051778989.posts smoothness.top_25_smooth

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970010296723265728


For feedback, file a bug with component Speed>Bisection
Cc: warx@chromium.org vmi...@chromium.org xiy...@chromium.org
Cc-ing CL reviewers xiyuan and warx: Looks like this CL caused a regression in smoothness on several Mac test cases. Can one of you take a look? Also cc-ing test owner vmiura for thoughts on how severe the regression is.
The CL modifies app list code which should no longer running on mac. IMHO, it does not look like to be the culprit.
I'm not confident in the bisect result in #3.  #5 kicked off a bisect on frame_times for plus.google.com, which hopefully will give a clearer culprit.

=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: INFRA_FAILURE

The bisect was able to narrow the range, you can try running with:
  good_revision: 592ae32947606f96fa9529342b4e3a6b6b7ada3c
  bad_revision : 34778b943933b6d3d9242a618d195e3c15edc27d

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : frame_times/https___plus.google.com_110031535020051778989_posts

Revision             Result                   N
chromium@497405      17.5747 +- 0.987005      14      good
chromium@497430      17.408 +- 0.698801       14      good
chromium@497454      17.2927 +- 0.778034      14      bad
chromium@497502      17.2 +- 0.594508         9       bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...plus.google.com.110031535020051778989.posts smoothness.top_25_smooth

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966193849591450720


For feedback, file a bug with component Speed>Bisection
The bisect didn't run to completion, but it doesn't look like it reproduced the regression either. vmiura, should we try a different bot?

Comment 10 by hejq@chromium.org, Oct 10 2017

Hi, I cannot think of any relation between the changes and the regression.
Have you got more update or information?
Status: WontFix (was: Assigned)
Not sure what more can be done at this point.

Sign in to add a comment