New issue
Advanced search Search tips

Issue 759548 link

Starred by 1 user
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Aug 2017
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add presubmit check for preventing use of std::regex

Project Member Reported by estevenson@chromium.org, Aug 28 2017 
In  issue 755321 , using std::regex caused a 28 kb binary size regression. Switching to re2::RE2 fixed the regression.

Are there any reasons we shouldn't add a presubmit check for this? Is src/PRESUBMIT.py the right place for this?
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b47b44cccc5465e696cfc5904a27da365cc0686

commit 6b47b44cccc5465e696cfc5904a27da365cc0686
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed Aug 30 20:41:57 2017

Add PRESUBMIT check for std::regex.

Since re2 is already used elsewhere in Chrome, we should use it to
avoid unnecessary binary size regressions caused by std::regex.

Bug:  759548 
Change-Id: Ic3d8b251dc0757fabff61d6c6b778799151a625c
Reviewed-on: https://chromium-review.googlesource.com/642587
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498599}
[modify] https://crrev.com/6b47b44cccc5465e696cfc5904a27da365cc0686/PRESUBMIT.py

Comment 2 by estevenson@chromium.org, Aug 30 2017

Status: Fixed (was: Available)
►

Sign in to add a comment