New issue
Advanced search Search tips

Issue 759546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Project Member Reported by henrika@chromium.org, Aug 28 2017

Issue description

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

Seems like ChromeUpdatesEventsApiTest.ChromeUpdates is flaky.

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3436e1746ad149b739a244401d24a10964c2b560

commit 3436e1746ad149b739a244401d24a10964c2b560
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Aug 29 14:24:46 2017

[Extensions] De-flake ChromeUpdatesEventsApiTest.ChromeUpdates

ChromeUpdatesEventsApiTest.ChromeUpdates waits for a message to be
sent from an extension background page when it's woken up for a
chrome_updated event. However, there's a chance that the extension
could already have woken up and received the event before we can
register an extension listener.

Remove the message listening aspect, since there's not a good way of
ensuring determinism while testing it, and instead rely on the views
created for the given extensions (which should be sufficient).

Bug:  759546 
Change-Id: I4d0afa89139b905710cba434758b8f8121fcb154
Reviewed-on: https://chromium-review.googlesource.com/639355
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498104}
[modify] https://crrev.com/3436e1746ad149b739a244401d24a10964c2b560/chrome/browser/extensions/events_apitest.cc
[modify] https://crrev.com/3436e1746ad149b739a244401d24a10964c2b560/chrome/test/data/extensions/api_test/lazy_events/chrome_updates/listener/background.js
[modify] https://crrev.com/3436e1746ad149b739a244401d24a10964c2b560/chrome/test/data/extensions/api_test/lazy_events/chrome_updates/non_listener/background.js

Comment 2 by hbos@chromium.org, Aug 30 2017

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Looks like this is fixed now, I don't see the same error on the bot anymore?
I'll leave it up to you, removing sheriff label.
Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment