Regression: Content of page is not properly seen after clicking on MIDI devices option.
Reported by
vku...@etouch.net,
Aug 28 2017
|
||||||
Issue descriptionChrome Version : 62.0.3198.0 (Official Build) (64-bit) (cohort: win_60_113)Revision 3ea904e3488e7af8b03e29fc71d9b9998ffc325b-refs/heads/master@{#497674} (32/64 Bit) OS:Windows(7,8,10), Mac(10.11.6, 0.12.3,10.12.5),Linux(14.04 LTS). What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://settings/content (2)Scroll down and click on "MIDI devices" and observe Actual: Content of page is not properly seen after clicking on MIDI devices option. Expected: Content of page should be properly seen after clicking on MIDI devices option. This is a regression issue broken in 'M62' and below is the manual regression range Good Build: 62.0.3197.0 Bad Build: 62.0.3198.0
,
Aug 28 2017
Adding blocker label, please undo if not the case.
,
Aug 30 2017
Removing release blocker because it doesn't affect functionality.
The change in rendering was due to fixing a bug in Blink that some overflow clips were applied to positioned descendants when they shouldn't.
Reassigning to michaelpg@ who worked on MD Settings animation before. Feel free to reassign. I'll offer assistance in CSS too.
The basic structure of the page (roughly) looks like this:
<style>
#container {
position: relative;
overflow: auto;
}
#card {
box-shadow: ...;
overflow: hidden;
}
.iron-selected {
position: static;
}
settings-subpage {
position: absolute;
}
</style>
<div id="container">
<div id="card">
<settings-subpage class="iron-selected">...</settings-subpage>
<settings-subpage>...</settings-subpage>
</div>
</div>
Only the currently selected subpage will be position:static, this is because we only want to count its layout overflow as scrollable contents.
Subpages that are fading out will have position:absolute, not counted as scrollable contents for being out-of-flow. Now the problem is that having position:absolute implies #card is no longer its containing block, thus its overflow clip no longer applies.
Adding position:relative to #card will workaround the clip leak, but I'm not sure it is what the UI designer intended. There is still a noticeable glitch when the animation starts, that the fading-out subpage jumps up, due to resetting scroll position of #container prematurely.
,
Sep 29 2017
Oops, didn't see this. Is it still occurring? Reassigning since I'm not working on Settings anymore.
,
Oct 4 2017
Scott, it looks like this would be eliminated by changing the animations to fades. What's the timeframe on that change?
,
Nov 1 2017
I can't reproduce this on ToT. We could do a bisect and find which CL actually fixed it. Regarding changing the animation to fades and changing how they work in general (separate scroll containers), like https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/view_manager.html, I think it is worth doing, but realistically this would require a lot of work to plug into Settings, and it is unclear whether we will get to it anytime soon.
,
Dec 1 2017
Can't repro +1, closing as fixed. Please reopen if issue still persists. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vku...@etouch.net
, Aug 28 2017Owner: trchen@chromium.org
Status: Assigned (was: Unconfirmed)
487 KB
487 KB View Download