Regression: Unwanted popup is opening while performing an audit on chrome://dino page |
|||||||||
Issue descriptionChrome Version:62.0.3198.0 OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and open devtools in chrome://dino page (2)Perform an audit and observe Actual:Unwanted popup is opening while performing an audit Expected:Instead, no popup should be seen This is a Regression issue broken in M-62 Manual Bisect Info: =================== Good Build:62.0.3197.0 Bad Build: 62.0.3198.0
,
Aug 28 2017
Unable to reproduce the issue on windows with latest #62.0.3198.2 dev as timeout reached error is occuring.
,
Aug 28 2017
Unable to get bad builds in bisect.. So, considering the one which fails to perform an audit as bad build and the one which performs audit as good build Hence updating the corrected manual bisect: Good Build:62.0.3187.0 Bad Build: 62.0.3188.0 In windows and mac also unable to perform audit Hence, adding Windows and mac label
,
Aug 28 2017
Bisect Information: =================== You are probably looking for a change made after 494804 (known good), but no later than 494810 (first known bad). Change Log: Suspecting https://chromium.googlesource.com/chromium/src/+/71f48559772345f1005a0e24eb27b01feada9439 from above URL @alexmos:Could you please take a look and reassign to the right owner if it is not related to your change. Thanks!
,
Aug 28 2017
,
Aug 28 2017
Bisect result: ============== https://chromium.googlesource.com/chromium/src/+log/7c775957071a0c19b8e39ec1087cf8daefe9d00b..a604b6e8d467a2c9a9dc134b1ca6f729b410052f
,
Aug 28 2017
I suspect it's my change, since in the expected video I see what looks like an explicit navigation to data:text/html,chromewebdata, the old chrome error URL, which ends up loading "chromewebdata" on the page. This won't work anymore with the new chrome error URL, chrome-error://chromewebdata/. Web pages aren't really supposed to navigate to that URL, and I put in logic to block such navigations, but looks like this is a way to still get the navigation through, as the popup is the external protocol dialog. keerthana.v@techmahindra.com: do you know if this was with PlzNavigate enabled? If you aren't sure, can you post the variations from chrome://version? dgozman@: do you know why running an audit on the chrome://dino page results in a navigation to the chrome error URL? And can we avoid doing that? Also, I can't repro this on Linux ToT, as I'm getting the following errors from the audit: [31228:31228:0828/095850.098667:ERROR:CONSOLE(0)] "Failed to load https://chrome-devtools-frontend.appspot.com/serve_file/@86ad07b2107401509cca42258ae5e7849b988f36/audits2_worker/audits2_worker_module.js: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'chrome-devtools://devtools' is therefore not allowed access. The response had HTTP status code 404.", source: chrome-devtools://devtools/bundled/inspector.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@86ad07b2107401509cca42258ae5e7849b988f36/&can_dock=true&dockSide=undocked (0) [31228:31228:0828/095850.099868:ERROR:CONSOLE(22)] "Empty response arrived for script 'https://chrome-devtools-frontend.appspot.com/serve_file/@86ad07b2107401509cca42258ae5e7849b988f36/audits2_worker/audits2_worker_module.js'", source: chrome-devtools://devtools/bundled/audits2_worker.js?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@86ad07b2107401509cca42258ae5e7849b988f36/ (22) [31228:31228:0828/095850.104795:ERROR:CONSOLE(1)] "Uncaught (in promise) ReferenceError: Audits2Service is not defined", source: chrome-devtools://devtools/bundled/audits2_worker.js?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@86ad07b2107401509cca42258ae5e7849b988f36/ (1) Do I need to do something special to enable audits on my build? Finally, if this only affects audits of the dino page, I don't see this as a Pri-1 issue. If someone disagrees, please let me know.
,
Aug 28 2017
I think Audits should be disabled for chrome:// pages. Patrick?
,
Aug 28 2017
We were originally keeping it open since the history/settings teams were using Lighthouse for performance measurement, but it seems to be causing a lot more trouble then its worth in a number of areas like this. We'll disable from our side as well.
,
Aug 29 2017
Attached is the variations from chrome://version and Also attaching the actual video
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b61d96e7ce66c12650fd9d7bf83fce4365636c9 commit 2b61d96e7ce66c12650fd9d7bf83fce4365636c9 Author: Patrick Hulce <phulce@chromium.org> Date: Wed Sep 06 17:04:58 2017 DevTools: limit audits to http, prevent bug report for known issues * Limits audit ability to sites on http or chrome-extension protocols. * Displays a "Try Again" message in lieu of bug report link for a set of known issues. * Fixes a bug where URLs were not constructed with encodeURIComponent. BUG= 759477 , 762323 Change-Id: Ia866e9164107985c28e1c477bb2453570e80d298 Reviewed-on: https://chromium-review.googlesource.com/639032 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#499993} [modify] https://crrev.com/2b61d96e7ce66c12650fd9d7bf83fce4365636c9/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
,
Sep 6 2017
Audits should now be disabled for all chrome://* pages.
,
Sep 7 2017
Retested issue in latest canary #63.0.3208.0 on Windows(7,8,10), Linux(14.04 LTS) & Mac(10.11.6, 10.12.3, 10.12.5) OS and issue is fixed now as per comment #12 Kindly review an attached screen cast
,
Sep 8 2017
Thanks for the fix, phulce@! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by brajkumar@chromium.org
, Aug 28 2017