New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759462 link

Starred by 1 user
Status: Fixed
Owner:
█ junwei...@intel.com
Last visit > 30 days ago
Closed: Sep 2017
Cc:
reillyg@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Throw javascript exception when detector fail from platform implementation

Project Member Reported by junwei...@intel.com, Aug 28 2017 
Throw javascript exception when google services is not available so that developer can notify user to install google play services.

And notify user to try it again later when the GMS required dependencies is not available locally.

And notify user the detected image is invalid from the javascript exception.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e974d892054aaf5ed122d37329c25aaa1010a96f

commit e974d892054aaf5ed122d37329c25aaa1010a96f
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Aug 31 22:21:31 2017

Report text and barcode detection unavailable without GMSCore

This change is a partial fix for  issue 759462 . Instead of reporting no
detection results the TextDetector and BarcodeDetector objects will now
report that they are unsupported when detect() is called on a device
without Google Play Services installed.

Bug:  759462 
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Change-Id: I6ad07fbad7e041ae5bef03458bb6250a5bfc245b
Reviewed-on: https://chromium-review.googlesource.com/646489
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499044}
[modify] https://crrev.com/e974d892054aaf5ed122d37329c25aaa1010a96f/services/shape_detection/android/java/src/org/chromium/shape_detection/BarcodeDetectionImpl.java
[modify] https://crrev.com/e974d892054aaf5ed122d37329c25aaa1010a96f/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java

Comment 2 by reillyg@chromium.org, Sep 6 2017

Cc: mcasas@chromium.org reillyg@chromium.org
Labels: OS-Android
Status: Fixed (was: Started)
Based on a discussion with the web platform predictability team our desire is to leave the GMSCore-specific errors out of the interface exposed to web content. As such I'm marking this issue as fixed based on the patch above.
►

Sign in to add a comment