New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759456 link

Starred by 1 user
Status: Started
Owner:
rijubrat...@intel.com
Cc:
geoffl...@chromium.org
█ hubbe@chromium.org
piman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Add and record UMA for R16_EXT and LUMINANCE_F16.

Project Member Reported by rijubrat...@intel.com, Aug 28 2017 
Add and record UMA stats for R16_EXT and LUMINANCE_F16 as it would be nice to get rid of one or the other eventually.
R16 is more forward-looking (since it's standard on recent desktop GL, whereas LUMINANCE formats have been removed from the Core profile).

Once we make sure that R16_EXT is more prevalent and performant (in terms of CPU power among other criteria) than LUMINANCE_F16, we can flip the switch (make R16_EXT as default) and remove LUMINANCE_F16.


Related Bugs: 624436,  445071
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef9c096fc0a1bc1d11a17f94c79c9dcd9323139c

commit ef9c096fc0a1bc1d11a17f94c79c9dcd9323139c
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Tue Sep 19 07:55:16 2017

Add histograms for LUMINANCE_F16 and R16_EXT.

Add and record UMA for R16_EXT and LUMINANCE_F16.
We add the UMA for both these formats as it would be nice to get
rid of one or the other eventually.

Bug: 759456
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iaee25dff684312229ceb408dbfde76985e566629
Reviewed-on: https://chromium-review.googlesource.com/635463
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502795}
[modify] https://crrev.com/ef9c096fc0a1bc1d11a17f94c79c9dcd9323139c/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/ef9c096fc0a1bc1d11a17f94c79c9dcd9323139c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ef9c096fc0a1bc1d11a17f94c79c9dcd9323139c/tools/metrics/histograms/histograms.xml

Comment 2 by hubbe@chromium.org, Nov 29 2017 

I tried using --enable-features=use-r16-texture on an nvidia GPU today, which made HDR video not work. (uniform green) Not sure what goes wrong yet.

Comment 3 by hubbe@chromium.org, Nov 29 2017 

The error is:

gles2_cmd_decoder_autogen.h(4285) GL ERROR : GL_INVALID_ENUM : glTexStorage2DEXT: internalFormat was GL_R16_EXT

Now, to see if I can fix it...

Comment 4 by hubbe@chromium.org, Nov 29 2017

Cc: geoffl...@chromium.org
Interestingly, --enable-features=use-r16-texture --use-cmd-decoder=passthrough works.

Comment 5 by hubbe@chromium.org, Dec 1 2017 

Got a little further, but now it says:

texture_manager.cc(2495( GL_ERROR: GL_INVALID_OPERATION : glTexSubImage: invalid internalformat/format/type combination GL_FALSE/GL_RED_EXT/GL_UNSIGNED_SHORT

Comment 6 by rijubrat...@intel.com, Feb 15 2018 

hubbe@: Is it possible to share the UMA stats with non-googlers ? 

Maybe it helps us answer https://bugs.chromium.org/p/chromium/issues/detail?id=810591#c6

Comment 7 by hubbe@chromium.org, Feb 15 2018 

Approximate stats across all platforms and channels:

 R16 &  L16: 62%
 R16 & !L16:  2%
!R16 &  L16: 14%
!R16 & !L16: 21%

Comment 8 by rijubrat...@intel.com, Feb 16 2018 

thanks for the data
►

Sign in to add a comment