New issue
Advanced search Search tips

Issue 759455 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 724628



Sign in to add a comment

apparmor fails to build with libc++

Project Member Reported by manojgupta@chromium.org, Aug 28 2017

Issue description

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_toolchain/builds/222

apparmor-2.10.1-r1: x86_64-cros-linux-gnu-clang++ -O2 -pipe -O2 -pipe  -g       -clang-syntax -I/build/lakitu//usr/include  -Wall -Wsign-compare -Wmissing-field-initializers -Wformat-security -Wunused-parameter -std=gnu++0x -D_GNU_SOURCE    -c -o aare_rules.o aare_rules.cc

apparmor-2.10.1-r1: aare_rules.cc:26:10: fatal error: 'ext/stdio_filebuf.h' file not found
apparmor-2.10.1-r1: #include <ext/stdio_filebuf.h>
apparmor-2.10.1-r1:          ^~~~~~~~~~~~~~~~~~~~~
apparmor-2.10.1-r1: 1 error generated.

 
Labels: libcxx
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3161a25c6c708f86135b398c2a8c7e2b030181fc

commit 3161a25c6c708f86135b398c2a8c7e2b030181fc
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Aug 28 22:24:11 2017

apparmor: Fix building with libc++.

Apparmor uses GNU extension header file <ext/stdio_filebuf.h>.
It, therefore, cannot be built with libc++.

Patch out the use of <ext/stdio_filebuf.h> since there is no use of
its features. Apparmor still builds with this header file removed.

This is a no-op change since no feature from <ext/stdio_filebuf.h> is used.

upstream bug: https://bugs.launchpad.net/apparmor/+bug/1713542

BUG= chromium:759455 
TEST=apparmor builds with libc++ enabled.

Change-Id: Ide1d1e842156fb9f98a8e6c8298fcc5cf1125b53
Reviewed-on: https://chromium-review.googlesource.com/638830
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/3161a25c6c708f86135b398c2a8c7e2b030181fc/overlay-lakitu/sys-apps/apparmor/files/apparmor-2.10-libcxx.patch
[modify] https://crrev.com/3161a25c6c708f86135b398c2a8c7e2b030181fc/overlay-lakitu/sys-apps/apparmor/apparmor-2.10.1.ebuild
[rename] https://crrev.com/3161a25c6c708f86135b398c2a8c7e2b030181fc/overlay-lakitu/sys-apps/apparmor/apparmor-2.10.1-r2.ebuild

Status: Verified (was: Untriaged)

Sign in to add a comment