mgiuca, benwells, owencm: Do you have any opinions regarding the position of the context menu. I have a patch that adds the option to the top of the context menu. See attached screenshot.

Deleted: Open link in app.png 56.1 KB

	Open link in app.png 56.1 KB View Download

Ooh an icon!

I think it doesn't matter much since it'll have to go through UX review. Top is fine for now.

It's confusing that it says "Pokedex.org". I checked; this is legit the title of the app in its manifest :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599

commit 13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Sep 08 00:11:00 2017

desktop-pwas: Add 'Open in [App Name]' context menu option

If the DesktopPWAWindowing feature is enabled, adds a new
context menu option for links that are in scope of installed
Desktop PWAs.

The context menu option will open a new app window for [App Name].

MenuManager loads icons for extensions that add context menu items. This
patch makes it so that MenuManager also loads icons for Bookmark Apps.

Bug:  759447 
Change-Id: I19075c47cc4f99efe8c2052f44acc48c8ca2629d
Reviewed-on: https://chromium-review.googlesource.com/637430
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500445}
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/app/generated_resources.grd
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/extensions/common/api/app_runtime.idl
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/extensions/common/constants.h
[modify] https://crrev.com/13cd46aa7d6fdbf7879c6d18c403a34f4f4c1599/tools/metrics/histograms/enums.xml