New issue
Advanced search Search tips

Issue 759442 link

Starred by 1 user

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Task



Sign in to add a comment

Mojofy & onion soup dwrite_font_proxy.

Project Member Reported by slangley@chromium.org, Aug 28 2017

Issue description

- Change existing dwrite_font_proxy_messages from IPC to Mojo.
- Move the renderer side implementation to somewhere inside WebKit, maybe platform/fonts?
 
Cc: haraken@chromium.org
Summary: Mojofy & onion soup dwrite_font_proxy. (was: Mojofy & onion soup dwrite_font_proxy and )
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae42d324d6e2f1921b70c9f0a26f124d0207b198

commit ae42d324d6e2f1921b70c9f0a26f124d0207b198
Author: Sam McNally <sammc@chromium.org>
Date: Wed Jan 10 00:04:52 2018

Mojofy DWriteFontProxy.

Change IPC::SyncChannel restricted dispatch to not re-entrantly dispatch
an IPC with a restricted dispatch group during an outging sync mojo IPC.
Since mojo does not support restricted dispatch, mojo should be treated
the same as a SyncChannel without a restricted dispatch group.

Bug: 759442
Change-Id: I7f9ef69de3fcd676b5bfddef76f980d79da75a09
Reviewed-on: https://chromium-review.googlesource.com/835973
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ilya Kulshin <kulshin@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528176}
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/renderer_host/dwrite_font_proxy_message_filter_win.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/child_thread_impl.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/dwrite_font_proxy_init_impl_win.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/dwrite_font_proxy_init_impl_win.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/dwrite_font_proxy_win.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/font_fallback_win.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/font_fallback_win.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/child/dwrite_font_proxy/font_fallback_win_unittest.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/common/BUILD.gn
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/common/content_message_generator.h
[add] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/common/dwrite_font_proxy.mojom
[delete] https://crrev.com/6dc9179011b690c40e4f60b257ee622c15ab5c5e/content/common/dwrite_font_proxy_messages.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/app/mojo/content_gpu_manifest.json
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/app/mojo/content_plugin_manifest.json
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/app/mojo/content_utility_manifest.json
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/public/test/render_view_test.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/test/dwrite_font_fake_sender_win.cc
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/content/test/dwrite_font_fake_sender_win.h
[modify] https://crrev.com/ae42d324d6e2f1921b70c9f0a26f124d0207b198/ipc/ipc_sync_channel.cc

Owner: ----

Comment 4 by drott@chromium.org, Mar 6 2018

sammc@, great work, thank you. Can we mark this as fixed?

Comment 5 by drott@chromium.org, Mar 6 2018

Cc: drott@chromium.org

Sign in to add a comment