New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759439 link

Starred by 1 user
Status: Fixed
Owner:
█ pihsun@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Tiled view for parallel group tests.

Project Member Reported by hungte@chromium.org, Aug 28 2017 
Now we have parallel groups running in tabbed view, and it's time to plan for tiled view.

Partners requested to have the test programs running like what they did in Windows: to have each test running inside a standalone small window, instructing what to do, so they can have an operator accessing ports (if they don't conflict) at the same time.

For example, if we device has audio jack in left side and SD card in right side, the factory may want allow OP inserting headset and SD at the same time so he doesn't need to wait for one of the test to complete.

I think we can add a "tiled_ui" property in FactoryTest, that:

 - if is a list [x, y], then the max column and row is (x, y).
 - if false or null, don't enable tiled view.
 - non-list true can be alias to some default, say [3, 2].
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/295f72b364e848975b1c34750002fc469214dea7

commit 295f72b364e848975b1c34750002fc469214dea7
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Sep 11 07:17:00 2017

goofy.js: Add tiled layout.

Add a tiled layout manager that can display multiple test UI tiled.

The TileManager isn't use by goofy.js yet. The ability to specify UI
manager to use in test list and toggle between different UI layout would
be added in a later CL.

Also, most pytests may need to be changed to be able to show correctly
in small window.

BUG= chromium:759439 
TEST=make test
TEST=manually, chnage the goofy.testUIManager to TileManager, call
     setOptions({rows: 2, columns: 2}), and start a parallel test, see
     if things works correctly.

Change-Id: I83c9ebb3502b68c3dcdeb8cef6ad302b5b85dac0
Reviewed-on: https://chromium-review.googlesource.com/656749
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/js/test_ui/manager.js
[modify] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/js/test_ui/tab_manager.js
[add] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/js/test_ui/tile_manager.js
[modify] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/static/css/goofy.css
[modify] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/static/Makefile
[modify] https://crrev.com/295f72b364e848975b1c34750002fc469214dea7/py/goofy/js/goofy.js

Comment 2 by hungte@chromium.org, Sep 21 2017

Status: Started (was: Untriaged)

Comment 3 by pihsun@chromium.org, Oct 13 2017

Status: Fixed (was: Started)
Layout select is in http://crosreview.com/680720, and focus indicator in http://crosreview.com/684255, so works related to tiled UI is finished.

Comment 4 by hungte@chromium.org, Oct 13 2017 

fantastic. finally got the feature implemented :)

Can you revise generic test list to include some group doing tiled view as example?

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment