New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759432 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Back out of UI language override experiment

Project Member Reported by martis@chromium.org, Aug 28 2017

Issue description

An experiment was run for users in certain countries wherein translation was offered even for pages in the UI language: crbug.com/569219

The experiment has been disabled and we no longer require the associated logic; it should be cleaned up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8a5a59ddcf87c3955737847cf958b8dd8d4745

commit ff8a5a59ddcf87c3955737847cf958b8dd8d4745
Author: Michael Martis <martis@chromium.org>
Date: Fri Sep 01 07:13:39 2017

Removed logic for translate UI language override experiment.

The experiment has been disabled, so its logic is no longer required. Removing
it will simplify upcoming improvements to user language modeling.

Bug:  759432 
Change-Id: I2847d37c00b7d32641260f5f5ebad2f7ad4eba0a
Reviewed-on: https://chromium-review.googlesource.com/637434
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499147}
[modify] https://crrev.com/ff8a5a59ddcf87c3955737847cf958b8dd8d4745/components/translate/core/browser/BUILD.gn
[delete] https://crrev.com/f721f259f771dab64ef5c7be0ee8b97961fd8e70/components/translate/core/browser/translate_experiment.cc
[delete] https://crrev.com/f721f259f771dab64ef5c7be0ee8b97961fd8e70/components/translate/core/browser/translate_experiment.h
[delete] https://crrev.com/f721f259f771dab64ef5c7be0ee8b97961fd8e70/components/translate/core/browser/translate_experiment_unittest.cc
[modify] https://crrev.com/ff8a5a59ddcf87c3955737847cf958b8dd8d4745/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/ff8a5a59ddcf87c3955737847cf958b8dd8d4745/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/ff8a5a59ddcf87c3955737847cf958b8dd8d4745/components/translate/core/browser/translate_prefs.h

Status: Verified (was: Assigned)

Sign in to add a comment