Oilpan reference is used instead of WrapperTrace reference at IDBObserver. |
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.113 Safari/537.36 Steps to reproduce the problem: N/A What is the expected behavior? What went wrong? N/A Did this work before? N/A Does this work in other browsers? N/A Chrome version: 60.0.3112.113 Channel: stable OS Version: Flash Version: To prevent deadlock, We have to use WrapperTrace for some references. However, references at IDBObserver are still Oilpan references.
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cffe8acf7f2bdf8be6b9a97d1db2cef84177326 commit 2cffe8acf7f2bdf8be6b9a97d1db2cef84177326 Author: Sayaka Takayama <stakayama@google.com> Date: Mon Aug 28 13:11:23 2017 Changed Oilpan references to WrapperTrace references at IDBObserver. References at IDBObserver are still Oilpan references, which has a risk to lead unexpected death of IDBObserverCallback. So I declared and defined TraceWrapper for callback_ at IDBObserver. Bug: 759425 Change-Id: Ifdb01568cd75d85ae755fe271b8a9a019651b454 Reviewed-on: https://chromium-review.googlesource.com/637290 Commit-Queue: Sayaka Takayama <stakayama@google.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#497748} [modify] https://crrev.com/2cffe8acf7f2bdf8be6b9a97d1db2cef84177326/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp [modify] https://crrev.com/2cffe8acf7f2bdf8be6b9a97d1db2cef84177326/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dd6f8907d6da40ab422609534df0c28cf8357c1 commit 0dd6f8907d6da40ab422609534df0c28cf8357c1 Author: Sayaka Takayama <stakayama@google.com> Date: Wed Aug 30 01:21:51 2017 Changed Oilpan references to WrapperTrace references at IDBDatabase. References at IDBDatabase are still Oilpan references, which has a risk to lead unexpected death of IDBObserver. So I declared and defined TraceWrapper for observers_ at IDBDatabase. Bug: 759425 Change-Id: I56ede468033cde41dcb30df3c6ef32c7855098d9 Reviewed-on: https://chromium-review.googlesource.com/636790 Commit-Queue: Sayaka Takayama <stakayama@google.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#498330} [modify] https://crrev.com/0dd6f8907d6da40ab422609534df0c28cf8357c1/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp [modify] https://crrev.com/0dd6f8907d6da40ab422609534df0c28cf8357c1/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
,
Aug 30 2017
,
Aug 30 2017
Mark as Fixed on behalf of stakayama@.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac366e420209ac43689a344c15476f65d640088f commit ac366e420209ac43689a344c15476f65d640088f Author: Sayaka Takayama <stakayama@google.com> Date: Thu Aug 31 02:10:24 2017 v8binding: deleted V8IDBObserverCustom V8IDBObserverCustom is now unnecessary because I added TraceWrapper at https://crrev.com/c/636790 and https://crrev.com/c/637290 . So I deleted V8IDBObserverCustom.cpp. Bug: 759425 Change-Id: I2f4a56bb93b35333e9cb5e3b6a03aba13c723841 Reviewed-on: https://chromium-review.googlesource.com/642635 Commit-Queue: Sayaka Takayama <stakayama@google.com> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#498719} [delete] https://crrev.com/8ac1a9a33103cda63ddab3d9b74a88a677d4295d/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp [modify] https://crrev.com/ac366e420209ac43689a344c15476f65d640088f/third_party/WebKit/Source/bindings/modules/v8/custom/custom.gni [modify] https://crrev.com/ac366e420209ac43689a344c15476f65d640088f/third_party/WebKit/Source/modules/indexeddb/IDBObserver.idl [modify] https://crrev.com/ac366e420209ac43689a344c15476f65d640088f/third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by yukishiino@chromium.org
, Aug 28 2017Labels: -OS-Linux OS-All
Owner: yukishiino@chromium.org
Status: Assigned (was: Unconfirmed)