New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759418 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Browser crash is seen on adding workspace

Reported by pranjali...@etouch.net, Aug 28 2017

Issue description

Chrome Version: 62.0.3197.0 (Official Build) a19b1504d1a1f40e6c5358ec9880eb06b506b007-refs/heads/master@{#497604} (32/64 bit)

OS: Windows(7,8,10), Mac(10.11.6, 0.12.3,10.12.5),Linux(14.04 LTS).

Steps to reproduce:
1.Launch chrome , go to NTP, open devtools and run Audit(Wait until audit completes).
2.On Audits results page click on 'Performance' icon.
3.Go to Sources section, right click and add folder to workspace.
4.Observe.

 
Actual Result : Browser crash is seen on adding folder to workspace in sources section.
Expected Result :Browser crash should not be seen .

Crash Id:Uploaded Crash Report ID fec59463e2b5f944 (Local Crash ID: a8bfda80-ae00-42e1-ae29-3db443c6f71e).






 
Actual_Crash.mp4
2.6 MB View Download
Labels: M-62
Manual Bisect Info:
 
Good build: 60.0.3101.0
Bad build: 60.0.3102.0

Note: This issue is seen when new audit feature was introduced i.e from build #60.0.3102.0.
Cc: pnangunoori@chromium.org
Labels: hasbisect
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
As per-revision bisect didn’t give any results, providing details from normal bisect:

Good build: 60.0.3101.0 (471958)
Bad build: 60.0.3102.0 (472262)

You are probably looking for a change made after 472179 (known good), but no later than 472193 (first known bad).

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f0a3d1dc467162b8c481fe146b86d9f938eedf20..68d14c041a06c7a9acca3ec3113ce36324371d13

CL: https://chromium.googlesource.com/chromium/src/+/f53247a6fbf1240613a9a79be36b6a3650fd19ec

From the CL above, assigning the issue to the concern owner

@dgozman: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.6 and able to reproduce in latest Canary #62.0.3197.0

Stack trace for the Report ID: 198478604b9bed2e

Thread 0 (id: 5332) CRASHED [EXCEPTION_BREAKPOINT @ 0x000007fed4c4a270 ] MAGIC SIGNATURE THREAD
Stack Quality87%Show frame trust levels
0x000007fed4c4a270	(chrome.dll -devtools_ui_bindings.cc:781 )	DevToolsUIBindings::AddFileSystem(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x000007fed4c5369b	(chrome.dll -devtools_embedder_message_dispatcher.cc:89 )	`anonymous namespace'::ParseAndHandle<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const & __ptr64>
0x000007fed4c51d3a	(chrome.dll -devtools_embedder_message_dispatcher.cc:123 )	DispatcherImpl::Dispatch(base::Callback<void ,1,1> const &,std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::ListValue const *)
0x000007fed4c49529	(chrome.dll -devtools_ui_bindings.cc:616 )	DevToolsUIBindings::HandleMessageFromDevToolsFrontend(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)
0x000007fed3a3b237	(chrome.dll -ipc_message_templates.h:121 )	IPC::MessageT<DevToolsHostMsg_DispatchOnEmbedder_Meta,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,void>::Dispatch<content::DevToolsFrontendHostImpl,content::DevToolsFrontendHostImpl,void,void ( content::DevToolsFrontendHostImpl::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &)>(IPC::Message const *,content::DevToolsFrontendHostImpl *,content::DevToolsFrontendHostImpl *,void *,void ( content::DevToolsFrontendHostImpl::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &))
0x000007fed3a3b082	(chrome.dll -devtools_frontend_host_impl.cc:74 )	content::DevToolsFrontendHostImpl::OnMessageReceived(IPC::Message const &,content::RenderFrameHost *)
0x000007fed39dd11f	(chrome.dll -web_contents_impl.cc:802 )	content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl *,IPC::Message const &)
0x000007fed37d9acb	(chrome.dll -render_frame_host_impl.cc:792 )	content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const &)
0x000007fed391a1c1	(chrome.dll -render_process_host_impl.cc:2450 )	content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &)
0x000007fed418213b	(chrome.dll -ipc_channel_proxy.cc:329 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &)
0x000007fed3e26a6f	(chrome.dll -task_annotator.cc:59 )	base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *)
0x000007fed3dd8005	(chrome.dll -message_loop.cc:409 )	base::MessageLoop::RunTask(base::PendingTask *)
0x000007fed3dd8a25	(chrome.dll -message_loop.cc:508 )	base::MessageLoop::DoWork()
0x000007fed3e26ff0	(chrome.dll -message_pump_win.cc:173 )	base::MessagePumpForUI::DoRunLoop()
0x000007fed3e26c63	(chrome.dll -message_pump_win.cc:56 )	base::MessagePumpWin::Run(base::MessagePump::Delegate *)
0x000007fed3dfede3	(chrome.dll -run_loop.cc:111 )	base::RunLoop::Run()
0x000007fed3cf3ebf	(chrome.dll -chrome_browser_main.cc:1963 )	ChromeBrowserMainParts::MainMessageLoopRun(int *)
0x000007fed370b237	(chrome.dll -browser_main_runner.cc:142 )	content::BrowserMainRunnerImpl::Run()
0x000007fed3703e0c	(chrome.dll -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const &)
0x000007fed3c48097	(chrome.dll -content_main_runner.cc:705 )	content::ContentMainRunnerImpl::Run()
0x000007fed3c62629	(chrome.dll -main.cc:469 )	service_manager::Main(service_manager::MainParams const &)
0x000007fed3c4787b	(chrome.dll -content_main.cc:19 )	content::ContentMain(content::ContentMainParams const &)
0x000007fed33dcef7	(chrome.dll -chrome_main.cc:109 )	ChromeMain
0x000000013f2d7580	(chrome.exe -main_dll_loader_win.cc:202 )	MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks)
0x000000013f2d25da	(chrome.exe -chrome_exe_main_win.cc:271 )	wWinMain
0x000000013f36dec2	(chrome.exe -exe_common.inl:253 )	__scrt_common_main_seh
0x771a59cc	(kernel32.dll + 0x000159cc )	
0x773da560	(ntdll.dll + 0x0002a560 )	
0x7722baaf	(kernel32.dll + 0x0009baaf )	
0x7722baaf	(kernel32.dll + 0x0009baaf )	
Cc: dgozman@chromium.org
Owner: caseq@chromium.org

Comment 4 by caseq@chromium.org, Aug 30 2017

Cc: paulir...@chromium.org phulce@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27cf07c629cac8f6d0ab7221f19f747b24582d4f

commit 27cf07c629cac8f6d0ab7221f19f747b24582d4f
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Aug 31 19:55:07 2017

DevTools: allow #fragments in DevTools URLs

This keeps fragment identifiers when sanitizing DevTools URL. These are
now used in Audits (LH), which confuses sanity checks when performing
sensitive operations on back-end.

Bug:  759418 
Change-Id: Idedad05eb128a8723b42b1d14145ae8177bb025e
Reviewed-on: https://chromium-review.googlesource.com/646578
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498960}
[modify] https://crrev.com/27cf07c629cac8f6d0ab7221f19f747b24582d4f/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/27cf07c629cac8f6d0ab7221f19f747b24582d4f/chrome/browser/devtools/devtools_ui_bindings_unittest.cc

Comment 6 by caseq@chromium.org, Sep 1 2017

Status: Fixed (was: Assigned)

Sign in to add a comment