New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add uma logging for user visiting "chrome://settings/languages"

Project Member Reported by renjieliu@chromium.org, Aug 28 2017

Issue description


We only log the users who use chrome://settings/languages to check their language settings.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b350ff324fef0cde3ea10f7fa5178f4074844bc5

commit b350ff324fef0cde3ea10f7fa5178f4074844bc5
Author: Renjie Liu <renjieliu@chromium.org>
Date: Tue Sep 05 05:02:36 2017

Add uma logging for user visit language settings.

Bug:  759410 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibbd2b67ee368c7cb4fb0daa79aace64fc8c1a95c
Reviewed-on: https://chromium-review.googlesource.com/640273
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499557}
[modify] https://crrev.com/b350ff324fef0cde3ea10f7fa5178f4074844bc5/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/b350ff324fef0cde3ea10f7fa5178f4074844bc5/tools/metrics/histograms/histograms.xml

Labels: -Pri-3 Pri-2
Status: Fixed (was: Assigned)
Labels: Merge-Request-62
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 7 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36561d352d605e3792352e41a2e025699efc9690

commit 36561d352d605e3792352e41a2e025699efc9690
Author: Renjie Liu <renjieliu@chromium.org>
Date: Thu Sep 07 05:32:09 2017

Add uma logging for user visit language settings.

TBR=renjieliu@chromium.org

(cherry picked from commit b350ff324fef0cde3ea10f7fa5178f4074844bc5)

Bug:  759410 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibbd2b67ee368c7cb4fb0daa79aace64fc8c1a95c
Reviewed-on: https://chromium-review.googlesource.com/640273
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499557}
Reviewed-on: https://chromium-review.googlesource.com/654461
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#61}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/36561d352d605e3792352e41a2e025699efc9690/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/36561d352d605e3792352e41a2e025699efc9690/tools/metrics/histograms/histograms.xml

Sign in to add a comment