New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759325 link

Starred by 1 user
Status: Duplicate
Merged: issue 765625
Owner:
niklase@chromium.org
Closed: Sep 2017
Cc:
pnangunoori@chromium.org
emir...@chromium.org
jbroman@chromium.org
█ msrchandra@chromium.org
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in base::subtle::RefCountedThreadSafeBase::HasOneRef

Project Member Reported by ClusterFuzz, Aug 26 2017 
Detailed report: https://clusterfuzz.com/testcase?key=6506652781248512

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000002
Crash State:
  base::subtle::RefCountedThreadSafeBase::HasOneRef
  base::internal::WeakReferenceOwner::GetRef
  base::SupportsWeakPtr<media::WebMediaPlayerImpl>::AsWeakPtr
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=490547:490630

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6506652781248512

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.

Comment 1 by msrchandra@chromium.org, Aug 28 2017

Cc: msrchandra@chromium.org
Components: Blink>GetUserMedia
Labels: M-62 Test-Predator-Wrong
Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "ref_counted.cc" assigning to concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/ee96d561c0b6d4933f94ef181e8e0e8cc03b2d62

@jbroman -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by guidou@chromium.org, Aug 28 2017

Cc: mcasas@chromium.org jbroman@chromium.org
Owner: emir...@chromium.org
emircan@: This seems to be related with recent work on element capture / WebMediaPlayerImpl. Can you take a look or triage further?

Moving jbroman@ to cc, since this does not look related to the ref-counting mechanism itself.

Comment 3 by emir...@chromium.org, Sep 14 2017

Cc: -mcasas@chromium.org emir...@chromium.org
Owner: mcasas@chromium.org
mcasas@ can you PTAL. In order for a NULL deref there, |element.GetWebMediaPlayer()| should be NULL when passed from blink. How should we handle that case? It probably requires an exception.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp?q=HTMLMediaElementCapture.cpp&sq=package:chromium&dr

Comment 4 by mcasas@chromium.org, Sep 15 2017

Owner: niklase@chromium.org
Reassigning to niklase@ for triaging since I won't have cycles
for this any time soon what with my new team and such.

Comment 5 by mcasas@chromium.org, Sep 15 2017

Components: Blink>MediaStream>CaptureFromElement

Comment 6 by emir...@chromium.org, Sep 15 2017

Cc: pnangunoori@chromium.org
 Issue 765625  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Sep 16 2017

Labels: OS-Mac OS-Linux
Project Member

Comment 8 by ClusterFuzz, Sep 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4828642558607360 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 9 by emir...@chromium.org, Sep 29 2017

Mergedinto: 765625
Status: Duplicate (was: Verified)
The fix in  issue 765625  seems to fix this as well. Marking this as dup.
►

Sign in to add a comment