New issue
Advanced search Search tips

Issue 759291 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 834703
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

SamlTest.ScrapedMultiple flakey on CrOS ASan

Project Member Reported by kylec...@chromium.org, Aug 26 2017

Issue description

When I added browser_tests back to the CrOS ASan trybot and that test in particular was failing flakily. It looks like a crash not an ASan error.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1474c3ee4a892d535837c52d29dddfc75fe79f85

commit 1474c3ee4a892d535837c52d29dddfc75fe79f85
Author: kylechar <kylechar@chromium.org>
Date: Mon Aug 28 19:54:12 2017

Enable tests on CrOS ASan trybot.

Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have
failing test cases, so add a filter file for both.

Bug:  742623 ,  756844 ,  759291 
Change-Id: Iffe10dba5d17f8539ebf57c18c0ef40e4e6221da
Reviewed-on: https://chromium-review.googlesource.com/636397
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497851}
[modify] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/chromium.memory.json
[add] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/filters/browser_tests_cros_asan.filter
[add] https://crrev.com/1474c3ee4a892d535837c52d29dddfc75fe79f85/testing/buildbot/filters/unit_tests_cros_asan.filter

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/354d866de4a66eb05a285828d4931a83f34de7e2

commit 354d866de4a66eb05a285828d4931a83f34de7e2
Author: Henrik Andreasson <henrika@chromium.org>
Date: Tue Aug 29 09:17:55 2017

Revert "Enable tests on CrOS ASan trybot."

This reverts commit 1474c3ee4a892d535837c52d29dddfc75fe79f85.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=759944

Original change's description:
> Enable tests on CrOS ASan trybot.
> 
> Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have
> failing test cases, so add a filter file for both.
> 
> Bug:  742623 ,  756844 ,  759291 
> Change-Id: Iffe10dba5d17f8539ebf57c18c0ef40e4e6221da
> Reviewed-on: https://chromium-review.googlesource.com/636397
> Commit-Queue: kylechar <kylechar@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497851}

TBR=sky@chromium.org,kylechar@chromium.org

Change-Id: I63f9a5a2baddf69b0d74d85edb51fb11cff35139
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  742623 ,  756844 ,  759291 
Reviewed-on: https://chromium-review.googlesource.com/640710
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498060}
[modify] https://crrev.com/354d866de4a66eb05a285828d4931a83f34de7e2/testing/buildbot/chromium.memory.json
[delete] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/testing/buildbot/filters/browser_tests_cros_asan.filter
[delete] https://crrev.com/d4287fc3f51190e6e8c698e36903b47c464596b1/testing/buildbot/filters/unit_tests_cros_asan.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4933d77d77e88629508587e5c36420d2e102c358

commit 4933d77d77e88629508587e5c36420d2e102c358
Author: kylechar <kylechar@chromium.org>
Date: Tue Aug 29 17:32:36 2017

Enable tests on CrOS ASan trybot.

Enable browser_tests and unit_tests on CrOS ASan trybot. Both tests have
failing test cases, so add a filter file for both. Also add the filter
files to data_deps in the appropriate test. The missing data_deps caused
this CL to be reverted originally.

Bug:  742623 ,  756844 ,  759291 
Change-Id: If6f45f418d4afb7e17fd6c439aa90a9e4062cf08
Reviewed-on: https://chromium-review.googlesource.com/641210
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498153}
[modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/chrome/test/BUILD.gn
[modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/browser_tests_cros_asan.filter
[add] https://crrev.com/4933d77d77e88629508587e5c36420d2e102c358/testing/buildbot/filters/unit_tests_cros_asan.filter

Blocking: 742623
Cc: jdufault@chromium.org achuith@chromium.org xiy...@chromium.org alemate@chromium.org
 Issue 759071  has been merged into this issue.
Blocking: -742623
Mergedinto: 834703
Status: Duplicate (was: Available)

Sign in to add a comment