Provide better errors when binding a move-only type using std::move() to a RepeatingCallback |
||
Issue descriptionThe static assert that was added in https://chromium-review.googlesource.com/583976 was pretty useful, but the error is a bit hard to decipher. Perhaps we can special-case this case to emit a special warning that move-only types need to be bound with base::Passed() with repeating callback.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a09cb607e97ab6e4041919ce7b7d5a5dcbb7e033 commit a09cb607e97ab6e4041919ce7b7d5a5dcbb7e033 Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Aug 30 13:46:19 2017 Provide clearer errors for common mistakes with Bind and move-only types Bug: 759254 , 759362 Change-Id: I5de6c40c6ab3fbc816ccef031aa5e0fbc78593cc Reviewed-on: https://chromium-review.googlesource.com/636886 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#498444} [modify] https://crrev.com/a09cb607e97ab6e4041919ce7b7d5a5dcbb7e033/base/bind.h [modify] https://crrev.com/a09cb607e97ab6e4041919ce7b7d5a5dcbb7e033/base/bind_unittest.nc
,
Sep 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dcheng@chromium.org
, Aug 27 2017Status: Started (was: Available)