New issue
Advanced search Search tips

Issue 759253 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Transport RTT estimate may incorrectly be computed as 0

Project Member Reported by tbansal@chromium.org, Aug 26 2017 
0 percentile estimate of transport RTT in NQE (network quality estimator) is  lower than expected (http://shortn/_wrGRCw8bGB) with too many samples in bucket 0.

On debugging on Android phone, it seems that in some cases, reading RTT estimate from the TCP socket returns an incorrect value of 0 msec. We should discard such values to improve the prediction accuracy.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/937ca7a5bcddbf1112bbf7c3b34df02900f86108

commit 937ca7a5bcddbf1112bbf7c3b34df02900f86108
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Aug 28 18:25:49 2017

Discard non-positive RTT observations in socket watcher

In some cases, reading RTT from TCP socket may (incorrectly) give a 
value of 0 milliseconds. Discard these spurious values which may
affect accuracy.

Bug:  759253 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I423a82054c6c0238a88729575fdf8e4350e38293
Reviewed-on: https://chromium-review.googlesource.com/636772
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497809}
[modify] https://crrev.com/937ca7a5bcddbf1112bbf7c3b34df02900f86108/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/937ca7a5bcddbf1112bbf7c3b34df02900f86108/net/nqe/socket_watcher.cc

Comment 2 by tbansal@chromium.org, Aug 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment