New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759252 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Cc:
█ scottchen@chromium.org
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 760804



Sign in to add a comment

[MD settings] separate cookies exceptions and local data

Project Member Reported by dschuyler@chromium.org, Aug 26 2017 
in chrome://settings/content/cookies
we have both site exceptions and local data on the same page.
The local data can be very slow to load.
As a quick improvement and to allow metrics, separate the local data by making a sub-page and metrics for the cookies local data.

Comment 1 by dschuyler@chromium.org, Aug 26 2017

Labels: M-62

Comment 2 by dschuyler@chromium.org, Aug 29 2017

Status: Started (was: Assigned)

Comment 3 by hcarmona@chromium.org, Aug 29 2017 

Putting screenshot link here also: http://imgur.com/a/nsqQU (from CL)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08aa59e007192c6977df02f36bf06c93209a29fe

commit 08aa59e007192c6977df02f36bf06c93209a29fe
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Aug 29 21:49:40 2017

[MD settings] cookies local data to sub-page

This CL moves the cookies data and local storage list (two names for the
same data) out of the cookies content exceptions UI and into a sub-page
of it's former location. A new link row brings users to the cookie data
list.

Bug:  759252 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0146fa030f9a1a47abf7f7d7881fd87926a9e1c3
Reviewed-on: https://chromium-review.googlesource.com/640152
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498241}
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/app/settings_strings.grdp
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/08aa59e007192c6977df02f36bf06c93209a29fe/chrome/test/data/webui/settings/site_data_test.js

Comment 5 by dschuyler@chromium.org, Aug 31 2017

Blocking: 760804

Comment 6 by dschuyler@chromium.org, Aug 31 2017

Status: Fixed (was: Started)
►

Sign in to add a comment