New issue
Advanced search Search tips

Issue 759238 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Network error screen should be centered

Project Member Reported by wzang@chromium.org, Aug 25 2017

Issue description

Chrome Version: 62.0.3197.0
OS: Chrome

What steps will reproduce the problem?
(1) Open the add person screen when network is not connected. Observe that the screen is not centered.

 
Screenshot 2017-08-25 at 4.12.14 PM.png
276 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06d5588e6c9bfa022f61edefe7563c2c6bea9aa9

commit 06d5588e6c9bfa022f61edefe7563c2c6bea9aa9
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Aug 26 01:37:22 2017

Adjust network error page width to make it centered

Bug:  759238 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7af717a6dc9996013d09aa0373593bb7267d9c2
Reviewed-on: https://chromium-review.googlesource.com/636166
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497631}
[modify] https://crrev.com/06d5588e6c9bfa022f61edefe7563c2c6bea9aa9/chrome/browser/resources/chromeos/login/screen_error_message.css
[modify] https://crrev.com/06d5588e6c9bfa022f61edefe7563c2c6bea9aa9/chrome/browser/resources/chromeos/login/screen_error_message.js

Comment 2 by wzang@chromium.org, Aug 26 2017

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 26 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 9 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ketakid@google.com, Aug 26 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge for M61.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59f1561dcf52962bc76f7f2c1c27717737249c9a

commit 59f1561dcf52962bc76f7f2c1c27717737249c9a
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Aug 28 18:04:52 2017

Adjust network error page width to make it centered

TBR=wzang@chromium.org

(cherry picked from commit 06d5588e6c9bfa022f61edefe7563c2c6bea9aa9)

Bug:  759238 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7af717a6dc9996013d09aa0373593bb7267d9c2
Reviewed-on: https://chromium-review.googlesource.com/636166
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497631}
Reviewed-on: https://chromium-review.googlesource.com/638852
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#933}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/59f1561dcf52962bc76f7f2c1c27717737249c9a/chrome/browser/resources/chromeos/login/screen_error_message.css
[modify] https://crrev.com/59f1561dcf52962bc76f7f2c1c27717737249c9a/chrome/browser/resources/chromeos/login/screen_error_message.js

Comment 6 by wzang@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment