New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[CFM Test Automation] Enable existing audio tests for CFM using audiobox

Project Member Reported by harpreet@chromium.org, Aug 25 2017

Issue description

This is a tracking bug for enabling existing audio test for CFM devices.

More info on which tests are to be enabled can be found here:
https://docs.google.com/spreadsheets/d/13UaulEqc5jP1zrcsBawf3Fgf_ZhI_GjaF_wDnfk2434/edit#gid=0



Here is the first CL that has already been submitted:
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/630580
 
Cc: cychiang@chromium.org
Cc: fredric@google.com
Summary: [CFM Test Automation] Enable existing audio tests for CFM using audiobox (was: [CFM Test Automation] Enable existing audio tests for CFM)
Some additional info about this...

These tests run in a Audiobox using Chameleon / audio board. At the moment, we have one bluestreak setup with guado (i7 + kepler) with Atrus in a Audiobox that will be running these tests.
Cc: katierh@chromium.org malmnas@chromium.org

Comment 4 by fredric@google.com, Aug 26 2017

Cc: wilhelmsson@google.com wirebrand@chromium.org mpalmqvist@google.com mberggren@google.com
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0614056a6a39c69131f089776de9890b88ffd4c7

commit 0614056a6a39c69131f089776de9890b88ffd4c7
Author: Dinesh Kumar Sunkara <dsunkara@chromium.org>
Date: Sat Aug 26 07:27:43 2017

[AutoTests] Updated Audio tests to run on CFM devices.

Updated applicable audio tests to run on chromeboxes (CFM)
on which there is no on board internal speaker. The test now
looks for information in control file for attached USB speaker
with dependency "usb_speaker" and shall only run this test on
devices with usb_speakers attached.

BUG= chromium:759235 
TEST=Tested locally on Guado+Chameleon setup

Change-Id: I8795f3ed1cb4bbf19cb4733520bd87f4990ceeb8
Reviewed-on: https://chromium-review.googlesource.com/636180
Commit-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>
Tested-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[add] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioBasicInternalMicrophone/control.atrus_mic
[add] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioAfterReboot/control.atrus_mic
[modify] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioVolume/audio_AudioVolume.py
[add] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioAfterReboot/control.atrus_speaker
[add] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioVolume/control.atrus_speaker
[modify] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioAfterReboot/audio_AudioAfterReboot.py
[modify] https://crrev.com/0614056a6a39c69131f089776de9890b88ffd4c7/server/site_tests/audio_AudioBasicInternalMicrophone/audio_AudioBasicInternalMicrophone.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2ab3ca003ec97fee8924f6a6881736cd3573fbde

commit 2ab3ca003ec97fee8924f6a6881736cd3573fbde
Author: Dinesh Kumar Sunkara <dsunkara@chromium.org>
Date: Thu Aug 31 21:19:59 2017

Updated AudioBasicInternalMicrophone to check nodes correctly.

In my previous CL, I missed to check the nodes correctly and
swapped between input and output nodes. Hence correcting the
same.

BUG= chromium:759235 
TEST=Tested locally on Guado

Change-Id: Ic1a9a5b7d413ee65d7fc690a3009c77d99072c1e
Reviewed-on: https://chromium-review.googlesource.com/641914
Commit-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>
Tested-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/2ab3ca003ec97fee8924f6a6881736cd3573fbde/server/site_tests/audio_AudioBasicInternalMicrophone/audio_AudioBasicInternalMicrophone.py

Project Member

Comment 8 by sheriffbot@chromium.org, Sep 1 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 1 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2fe1afe0ef344fb556d910f173246d1bfc8f29eb

commit 2fe1afe0ef344fb556d910f173246d1bfc8f29eb
Author: Dinesh Kumar Sunkara <dsunkara@chromium.org>
Date: Fri Sep 01 21:41:29 2017

[AutoTests] Updated Audio tests to run on CFM devices.

Updated applicable audio tests to run on chromeboxes (CFM)
on which there is no on board internal speaker. The test now
looks for information in control file for attached USB speaker
with dependency "usb_speaker" and shall only run this test on
devices with usb_speakers attached.

BUG= chromium:759235 
TEST=Tested locally on Guado+Chameleon setup

Change-Id: I8795f3ed1cb4bbf19cb4733520bd87f4990ceeb8
Reviewed-on: https://chromium-review.googlesource.com/636180
Commit-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>
Tested-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
(cherry picked from commit 0614056a6a39c69131f089776de9890b88ffd4c7)
Reviewed-on: https://chromium-review.googlesource.com/648335
Commit-Queue: Dinesh Kumar Sunkara <dsunkara@google.com>
Trybot-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>

[add] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioBasicInternalMicrophone/control.atrus_mic
[add] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioAfterReboot/control.atrus_mic
[modify] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioVolume/audio_AudioVolume.py
[add] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioAfterReboot/control.atrus_speaker
[add] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioVolume/control.atrus_speaker
[modify] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioAfterReboot/audio_AudioAfterReboot.py
[modify] https://crrev.com/2fe1afe0ef344fb556d910f173246d1bfc8f29eb/server/site_tests/audio_AudioBasicInternalMicrophone/audio_AudioBasicInternalMicrophone.py

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e483575ea455dbf77da1a77b8ae7512b49162de2

commit e483575ea455dbf77da1a77b8ae7512b49162de2
Author: Dinesh Kumar Sunkara <dsunkara@chromium.org>
Date: Fri Sep 01 22:13:30 2017

Updated AudioBasicInternalMicrophone to check nodes correctly.

In my previous CL, I missed to check the nodes correctly and
swapped between input and output nodes. Hence correcting the
same.

BUG= chromium:759235 
TEST=Tested locally on Guado

Change-Id: Ic1a9a5b7d413ee65d7fc690a3009c77d99072c1e
Reviewed-on: https://chromium-review.googlesource.com/641914
Commit-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>
Tested-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Dinesh Kumar Sunkara <dsunkara@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
(cherry picked from commit 2ab3ca003ec97fee8924f6a6881736cd3573fbde)
Reviewed-on: https://chromium-review.googlesource.com/648223
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Commit-Queue: Dinesh Kumar Sunkara <dsunkara@google.com>
Trybot-Ready: Dinesh Kumar Sunkara <dsunkara@google.com>

[modify] https://crrev.com/e483575ea455dbf77da1a77b8ae7512b49162de2/server/site_tests/audio_AudioBasicInternalMicrophone/audio_AudioBasicInternalMicrophone.py

Project Member

Comment 12 by sheriffbot@chromium.org, Sep 5 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-61
Status: Fixed (was: Started)

Sign in to add a comment