Auto-rotate the screen with system tray open doesn't render the system tray correctly |
|||||||||
Issue descriptionChrome Version: 62.0.3195.0 OS: Chrome OS What steps will reproduce the problem? (1) Enter into tablet mode (2) Open the system tray bubble (3) Rotate the screen What is the expected result? The system tray should render correctly What happens instead? Half the system tray bubble is visible while the other half is invisible. It's 100% reproducable. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934 commit cd71d8389dcf9d2e64a7f01cbf5af97c01b38934 Author: MinChen <minch@chromium.org> Date: Wed Aug 30 18:35:34 2017 Update the clipping window bounds if tray bubble anchor updated. In tablet mode, the tray bubbles are clipped by a clipping window. If the anchor (tray or bubble) changes, should update the bounds of the clipping window at the same time to make sure they can be clipped correctly. Test: Tested locally Bug: 759233 Change-Id: I8e3bfec21cda70e16e43273a4b0a8b9b7aa0f082 Reviewed-on: https://chromium-review.googlesource.com/642728 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#498545} [modify] https://crrev.com/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934/ash/system/palette/palette_tray.cc [modify] https://crrev.com/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934/ash/system/tray/system_tray.cc [modify] https://crrev.com/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934/ash/system/tray/tray_background_view.cc [modify] https://crrev.com/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934/ash/system/tray/tray_background_view.h [modify] https://crrev.com/cd71d8389dcf9d2e64a7f01cbf5af97c01b38934/ash/system/web_notification/web_notification_tray.cc
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc369f2ae8c48e1a214ad71bb752c60deb8618fb commit fc369f2ae8c48e1a214ad71bb752c60deb8618fb Author: MinChen <minch@chromium.org> Date: Tue Sep 12 17:43:01 2017 Update status area tray clipping window bounds when auto-rotate the screen with tray bubble opened. Changes: 1. Call TrayBackgroundView::Inialize in PaletteTray::Initialize to add the widget observer for palette tray widget. Then when palette tray anchor changed its AnchorUpdated() can be called. 2. Call SystemTray's UpdateClippingWindowBounds() in WebNotificationTray::UpdateAnchored(). Since when the shelf is bottom alignment, the anchor tray of WebNotificationTray bubble is SystemTray. Bug: 759233 Change-Id: I036e3d2a58541398821424ed31b6534c50b5033b Reviewed-on: https://chromium-review.googlesource.com/653313 Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501329} [modify] https://crrev.com/fc369f2ae8c48e1a214ad71bb752c60deb8618fb/ash/system/palette/palette_tray.cc [modify] https://crrev.com/fc369f2ae8c48e1a214ad71bb752c60deb8618fb/ash/system/web_notification/web_notification_tray.cc
,
Sep 12 2017
,
Sep 29 2017
This need to be merged back to M61. See issue 769906 .
,
Sep 29 2017
,
Sep 29 2017
Issue 769906 has been merged into this issue.
,
Sep 29 2017
Talked with Albert offline, we do not need to merge back to M61. Remove the block and merge request.
,
Sep 29 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 17 2017
,
Nov 8 2017
9901.66.0, 62.0.3202.82 kevin |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by minch@chromium.org
, Aug 30 2017