Refactor cookieStore usage in Chrome for iOS |
|||
Issue descriptionThere are many types of cookie stores in iOS, and too much code for legacy reasons. Also the current cookieStore doesn't work consistently and correctly (since migrating to WKWebView) Refactor CookieStores and allow integeration with WKWebCookieStore. Design Document: https://docs.google.com/document/d/17_AE5tuMf2NiCIpq7Ck9fG7WwbEvcEV7U8SlgqrpDBo
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8505818b354fa784d77723c2d8a7123d154770f5 commit 8505818b354fa784d77723c2d8a7123d154770f5 Author: Mohammad Refaat <mrefaat@chromium.org> Date: Thu Sep 28 15:31:26 2017 Convert SystemCookieStore to Async. * Converts SystemCookieStore to Async * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous functions. * Move creation time management to systemCookieStore. * Update cookie_store_ios_presistent_unittest & cookie_store_ios_unittests to account for SystemCookieStore changes * (As CookieStoreIOS is using systemCookieStore internally). Another CL is in progress to add WKSystemCookieStore & unit_tests for systemCookieStore (to handle async methods) with template for both NSHTTP & WK systemCookieStore. Bug: 759229, 759227 , 767948 Change-Id: I1c24c82540f4781a0bec77ebfa4a861ca7433391 Reviewed-on: https://chromium-review.googlesource.com/675804 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#505033} [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/chrome/app/startup/BUILD.gn [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/chrome/app/startup/client_registration.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/chrome/browser/net/chrome_cookie_store_ios_client.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/chrome/browser/net/chrome_cookie_store_ios_client.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_client.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_client.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_persistent_unittest.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_test_util.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_test_util.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/cookie_store_ios_unittest.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/ns_http_system_cookie_store.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/ns_http_system_cookie_store.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/ns_http_system_cookie_store_unittest.mm [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/system_cookie_store.h [modify] https://crrev.com/8505818b354fa784d77723c2d8a7123d154770f5/ios/net/cookies/system_cookie_store.mm
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d206d2687f548d544c46806e52e1ef4bb97189 commit e7d206d2687f548d544c46806e52e1ef4bb97189 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Sep 28 21:59:49 2017 Revert "Convert SystemCookieStore to Async." This reverts commit 8505818b354fa784d77723c2d8a7123d154770f5. Reason for revert: This CL is causing CookieStoreIOSTest.SameValueDoesNotCallHook to fail on iPhone 7, iOS 11 devices. Original change's description: > Convert SystemCookieStore to Async. > > * Converts SystemCookieStore to Async > * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous > functions. > * Move creation time management to systemCookieStore. > * Update cookie_store_ios_presistent_unittest & > cookie_store_ios_unittests to account for SystemCookieStore changes > * (As CookieStoreIOS is using systemCookieStore internally). > > Another CL is in progress to add WKSystemCookieStore & unit_tests for > systemCookieStore (to handle async methods) with template for both > NSHTTP & WK systemCookieStore. > > Bug: 759229, 759227 , 767948 > Change-Id: I1c24c82540f4781a0bec77ebfa4a861ca7433391 > Reviewed-on: https://chromium-review.googlesource.com/675804 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505033} TBR=mmenke@chromium.org,eugenebut@chromium.org,mrefaat@chromium.org Change-Id: I43c71a95910d14f4717111a66f0fb0556a91fb8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759229, 759227 , 767948 Reviewed-on: https://chromium-review.googlesource.com/691037 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#505178} [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/chrome/app/startup/BUILD.gn [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/chrome/app/startup/client_registration.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/chrome/browser/net/chrome_cookie_store_ios_client.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/chrome/browser/net/chrome_cookie_store_ios_client.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_client.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_client.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_persistent_unittest.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_test_util.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_test_util.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/cookie_store_ios_unittest.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/ns_http_system_cookie_store.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/ns_http_system_cookie_store.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/ns_http_system_cookie_store_unittest.mm [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/system_cookie_store.h [modify] https://crrev.com/e7d206d2687f548d544c46806e52e1ef4bb97189/ios/net/cookies/system_cookie_store.mm
,
Oct 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/336a087175cc8a996437609fa2f632939af44a87 commit 336a087175cc8a996437609fa2f632939af44a87 Author: mrefaat <mrefaat@chromium.org> Date: Wed Oct 04 22:46:11 2017 [Reland] Convert SystemCookieStore to Async. * Converts SystemCookieStore to Async * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous functions. * Move creation time management to systemCookieStore. * Update cookie_store_ios_presistent_unittest & cookie_store_ios_unittests to account for SystemCookieStore changes * (As CookieStoreIOS is using systemCookieStore internally). Another CL is in progress to add WKSystemCookieStore & unit_tests for systemCookieStore (to handle async methods) with template for both NSHTTP & WK systemCookieStore. Bug: 759229, 759227 , 767948 Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f Reviewed-on: https://chromium-review.googlesource.com/700818 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#506549} [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/chrome/app/startup/BUILD.gn [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/chrome/app/startup/client_registration.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/chrome/browser/net/chrome_cookie_store_ios_client.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/chrome/browser/net/chrome_cookie_store_ios_client.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_client.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_client.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_persistent_unittest.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_test_util.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_test_util.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/cookie_store_ios_unittest.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/ns_http_system_cookie_store.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/ns_http_system_cookie_store.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/ns_http_system_cookie_store_unittest.mm [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/system_cookie_store.h [modify] https://crrev.com/336a087175cc8a996437609fa2f632939af44a87/ios/net/cookies/system_cookie_store.mm
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2 commit f34616fb87c3d63e56a0268ce60fab1eb1d94ab2 Author: Matt Menke <mmenke@chromium.org> Date: Thu Oct 05 18:31:03 2017 Revert "[Reland] Convert SystemCookieStore to Async." This reverts commit 336a087175cc8a996437609fa2f632939af44a87. Reason for revert: This is breaking Cronet iOS tests. Sample trace: #0 0x0000000102c2e6b0 in net::RunCookieCallback(base::OnceCallback<void ()>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:25 #1 0x0000000102c2eb20 in net::NSHTTPSystemCookieStore::GetCookiesForURLAsync(GURL const&, base::OnceCallback<void (NSArray<NSHTTPCookie*>*)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/ns_http_system_cookie_store.mm:45 #2 0x0000000102c0f5b0 in net::CookieStoreIOS::GetCookieListWithOptionsAsync(GURL const&, net::CookieOptions const&, base::OnceCallback<void (std::__1::vector<net::CanonicalCookie, std::__1::allocator<net::CanonicalCookie> > const&)>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/cookies/cookie_store_ios.mm:459 #3 0x000000010380caec in net::URLRequestHttpJob::AddCookieHeaderAndStart() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:597 #4 0x000000010380c598 in net::URLRequestHttpJob::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request_http_job.cc:321 #5 0x00000001037e87d8 in net::URLRequest::StartJob(net::URLRequestJob*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:668 #6 0x00000001037e7ec4 in net::URLRequest::BeforeRequestComplete(int) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:613 #7 0x00000001037e7738 in net::URLRequest::Start() at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../net/url_request/url_request.cc:538 #8 0x0000000102c3a620 in net::HttpProtocolHandlerCore::Start(id<CRNNetworkClientProtocol>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../ios/net/crn_http_protocol_handler.mm:708 #9 0x0000000102c41130 in void base::internal::FunctorTraits<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), void>::Invoke<scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:194 #10 0x0000000102c41034 in void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::HttpProtocolHandlerCore::* const&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&>(void (net::HttpProtocolHandlerCore::* const&&&)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore> const&&&, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> const&&&) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:277 #11 0x0000000102c40fc0 in void base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::RunImpl<void const(&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&, 0ul, 1ul>(void const(&&&)(id<CRNNetworkClientProtocol>), std::__1::tuple<scoped_refptr, id<CRNHTTPProtocolHandlerProxy> > const&&&, void const(id<CRNNetworkClientProtocol>)::integer_sequence<unsigned long, 0ul, 1ul>) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:349 #12 0x0000000102c40ebc in base::internal::Invoker<base::internal::BindState<void (net::HttpProtocolHandlerCore::*)(id<CRNNetworkClientProtocol>), scoped_refptr<net::HttpProtocolHandlerCore>, base::scoped_nsprotocol<id<CRNHTTPProtocolHandlerProxy> __strong> >, void ()>::Run(base::internal::BindStateBase*) at /Users/kapishnikov/chrome/repo/ios/src/out/Debug-iphonesimulator/../../base/bind_internal.h:331 Original change's description: > [Reland] Convert SystemCookieStore to Async. > > * Converts SystemCookieStore to Async > * Add Async functions to NSHTTPSystemCookieStore and keep the synchronous > functions. > * Move creation time management to systemCookieStore. > * Update cookie_store_ios_presistent_unittest & > cookie_store_ios_unittests to account for SystemCookieStore changes > * (As CookieStoreIOS is using systemCookieStore internally). > > Another CL is in progress to add WKSystemCookieStore & unit_tests for > systemCookieStore (to handle async methods) with template for both > NSHTTP & WK systemCookieStore. > > Bug: 759229, 759227 , 767948 > Change-Id: If5e1fdb8d6424085d5212a3ea867968642db554f > Reviewed-on: https://chromium-review.googlesource.com/700818 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506549} TBR=eugenebut@chromium.org,mrefaat@chromium.org Change-Id: I7c653c57501745359ecb35ff422996545b7587f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759229, 759227 , 767948 Reviewed-on: https://chromium-review.googlesource.com/702974 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506798} [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/chrome/app/startup/BUILD.gn [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/chrome/app/startup/client_registration.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/chrome/browser/net/chrome_cookie_store_ios_client.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/chrome/browser/net/chrome_cookie_store_ios_client.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_client.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_client.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_persistent_unittest.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_test_util.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_test_util.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/cookie_store_ios_unittest.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/ns_http_system_cookie_store.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/ns_http_system_cookie_store.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/ns_http_system_cookie_store_unittest.mm [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/system_cookie_store.h [modify] https://crrev.com/f34616fb87c3d63e56a0268ce60fab1eb1d94ab2/ios/net/cookies/system_cookie_store.mm
,
Oct 27 2017
https://chromium-review.googlesource.com/c/chromium/src/+/704014 was submitted as a reland
,
Oct 27 2017
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b22b849d5ef25579cdbbba34b126d93d540956b7 commit b22b849d5ef25579cdbbba34b126d93d540956b7 Author: Mohammad Refaat <mrefaat@chromium.org> Date: Tue Nov 07 01:59:57 2017 Create WKHTTPSystemCookieStore WKHTTPSystemCookieStore is a SystemCookieStore that uses WKHTTPCookieStore as its internal cookie store. WKHTTPCookieStore is an async store that does it's callbacks on the main thread, from there we post the systemCookieStore callbacks to the webthread. Also created system_cookie_store unit tests to be a generic unit tests for all classes that implements systemCookieStore, and added NSHTTPSystemCookieStore unit test delegate & WKHTTPSystemCookieStore unit test delegate to use it. Bug: 759229, 759227 , 779106 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7d100e1f3e27b3cffea66506a4d20e6bdbc44927 Reviewed-on: https://chromium-review.googlesource.com/741883 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#514351} [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/net/BUILD.gn [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/net/cookies/ns_http_system_cookie_store_unittest.mm [add] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/net/cookies/system_cookie_store_unittest_template.h [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/testing/wait_util.h [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/testing/wait_util.mm [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/web/BUILD.gn [modify] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/web/net/cookies/BUILD.gn [add] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/web/net/cookies/wk_http_system_cookie_store.h [add] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/web/net/cookies/wk_http_system_cookie_store.mm [add] https://crrev.com/b22b849d5ef25579cdbbba34b126d93d540956b7/ios/web/net/cookies/wk_http_system_cookie_store_unittest.mm
,
Nov 16 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8 commit 04349b4ff2adfb7fab7a44f19d9889d537d7d6c8 Author: mrefaat <mrefaat@chromium.org> Date: Wed Dec 06 02:18:19 2017 Update WKSystemCookieStore and CookieCreationTimeManager Thread usage. 1- Updates WKSystemCookieStore so it can use wkcookiestore only from the main thread. 2- Update the CookieCreationTimeManager to only be used on IO thread (aside from creation on Main thread) Bug: 779106,759229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifa0f9e5bb2d2c33c488759467dc8a25403f6e0ed Reviewed-on: https://chromium-review.googlesource.com/809531 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521954} [modify] https://crrev.com/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8/ios/net/cookies/cookie_creation_time_manager.h [modify] https://crrev.com/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8/ios/net/cookies/cookie_creation_time_manager.mm [modify] https://crrev.com/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8/ios/net/cookies/system_cookie_store.h [modify] https://crrev.com/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8/ios/net/cookies/system_cookie_store.mm [modify] https://crrev.com/04349b4ff2adfb7fab7a44f19d9889d537d7d6c8/ios/web/net/cookies/wk_http_system_cookie_store.mm
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6501d96ec780bd2f60785d1187fe7f43e07dac8 commit a6501d96ec780bd2f60785d1187fe7f43e07dac8 Author: mrefaat <mrefaat@chromium.org> Date: Mon Dec 11 19:50:50 2017 Create SystemCookieStoreUtil to create WKHTTPSystemCookieStore. 1- Add Feature flag for WKSystemCookieStore usage. 2- Create SystemCookieStoreUtil to create the correct type of HTTPSystemCookieStore based on iOS version and the feature flag value. Bug: 779106,759229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie4da0c3c49ede43e27368ef40162cdd7bc164a34 Reviewed-on: https://chromium-review.googlesource.com/809307 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523178} [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/chrome/browser/ios_chrome_flag_descriptions.h [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/BUILD.gn [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/features.mm [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/net/cookies/BUILD.gn [add] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/net/cookies/system_cookie_store_util.mm [add] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/net/cookies/system_cookie_store_util_unittest.mm [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/public/BUILD.gn [modify] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/public/features.h [add] https://crrev.com/a6501d96ec780bd2f60785d1187fe7f43e07dac8/ios/web/public/system_cookie_store_util.h
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573 commit 03b21ae3bbcfbad78f7fa3a85b5b5e9334580573 Author: mrefaat <mrefaat@chromium.org> Date: Wed Dec 13 22:39:43 2017 Integrate WKHTTPSystemCookieStore with request context getter. Use SystemCookieStoreUtil to provide the requestContextGetter with the correct base cookie store (either NSHTTPCookieStore or WKHTTPCookieStore). This means that when WKHTTPCookieStore feature flag is enabled and it's iOS11+ cookie store will be using WKHTTPCookieStore. Bug: 779106,759229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I97695aef8c75d88861d0694c2cf4983447bfe128 Reviewed-on: https://chromium-review.googlesource.com/809744 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#523921} [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/browser_state/BUILD.gn [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h [rename] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/net/cookie_util.h [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/chrome/browser/net/cookie_util.mm [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/net/cookies/cookie_store_ios_persistent.h [modify] https://crrev.com/03b21ae3bbcfbad78f7fa3a85b5b5e9334580573/ios/net/cookies/cookie_store_ios_persistent.mm
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/107d07bc68a516d5dccc620c98a7bcb5408b7dd2 commit 107d07bc68a516d5dccc620c98a7bcb5408b7dd2 Author: Mohammad Refaat <mrefaat@chromium.org> Date: Fri Feb 16 02:29:01 2018 Enable WKHTTPCookieStore usage by default for iOS 11+ Bug: 759229, 779106 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia79cc0ba778e1b24de5cfddab2068f165b77d64e Reviewed-on: https://chromium-review.googlesource.com/922924 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#537109} [modify] https://crrev.com/107d07bc68a516d5dccc620c98a7bcb5408b7dd2/ios/web/features.mm
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb commit d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb Author: mrefaat <mrefaat@chromium.org> Date: Wed Aug 08 22:07:53 2018 Record time spent on browsing data removal. I added task_started time to RemovalTask structure, this was dropped when this class was ported from content. Bug: 796231, 759229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19f44ef3a72685b1fbe398e2915b8fd842307541 Reviewed-on: https://chromium-review.googlesource.com/1164571 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#581704} [modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl.h [modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm [modify] https://crrev.com/d1c3e6874f547060aae1b8bc9fc26ee58d7e08eb/ios/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.mm
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/516cd7cdcdf469220c867b2612e9b7f1ca61afa9 commit 516cd7cdcdf469220c867b2612e9b7f1ca61afa9 Author: mrefaat <mrefaat@chromium.org> Date: Wed Oct 10 17:19:02 2018 enable WKHTTPSystemCookieStore to be the default cookiestore in canary This will enable the new cookie store for M71 as the branch cut is after 2 days. Bug: 759229 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7af68f04408c136d60f58611f1c770cfee34e5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1269439 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#598378} [modify] https://crrev.com/516cd7cdcdf469220c867b2612e9b7f1ca61afa9/ios/web/features.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by mrefaat@chromium.org
, Sep 22 2017