New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759215 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove non-color-correct-rendering code paths

Project Member Reported by ccameron@chromium.org, Aug 25 2017

Issue description

Umbrella bug for patches to remove the non-color-correct-rendering paths.

 
First step is changing all cc and viz unittests to run with color correct rendering. Not all tests populate all required fields. List of bugs:

cc:
1 test failed:
    LayerTreeHostImplTest.RasterColorSpaceNoColorCorrection (../../cc/trees/layer_tree_host_impl_unittest.cc:12983)
14 tests crashed:
    LayerTreeHostContextTestDontUseLostResources.RunMultiThread_DelegatingRenderer
    LayerTreeHostContextTestDontUseLostResources.RunSingleThread_DelegatingRenderer
    LayerTreeHostTestSubmitFrameResources.RunMultiThread_DelegatingRenderer
    LayerTreeHostTestSubmitFrameResources.RunSingleThread_DelegatingRenderer
    VideoGLRendererPixelHiLoTest.ClippedYUVRect/0
    VideoGLRendererPixelHiLoTest.ClippedYUVRect/1
    VideoGLRendererPixelHiLoTest.OffsetYUVRect
    VideoGLRendererPixelHiLoTest.SimpleYUVARect
    VideoGLRendererPixelHiLoTest.SimpleYUVRect/0
    VideoGLRendererPixelHiLoTest.SimpleYUVRect/1
    VideoGLRendererPixelTest.FullyTransparentYUVARect
    VideoGLRendererPixelTest.SimpleNV12JRect
    VideoGLRendererPixelTest.SimpleYUVRectBlack
    VideoGLRendererPixelTest.YUVAEdgeBleed

viz:
1 test crashed:
    GLRendererTest.ActiveTextureState

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa8e283e1582cfae599f9a55c66fec29eea8304

commit 7fa8e283e1582cfae599f9a55c66fec29eea8304
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Sep 05 01:20:39 2017

color: Enable color correct rendering on all cc/viz tests

Fix a couple of bugs along the way, mostly where we didn't specify a
color space for YUV quads.

Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2490ff526ffa3f1c8841cf0751a641e0c9d1f835
Reviewed-on: https://chromium-review.googlesource.com/636170
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499530}
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/components/viz/common/display/renderer_settings.h
[modify] https://crrev.com/7fa8e283e1582cfae599f9a55c66fec29eea8304/components/viz/service/display/gl_renderer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da2054618ba98c20808fd3fcf0b6430426a51fcc

commit da2054618ba98c20808fd3fcf0b6430426a51fcc
Author: Christopher Cameron <ccameron@chromium.org>
Date: Fri Sep 08 21:24:29 2017

cc/viz: Require RenderPass color space always be valid

Removing a few more places where we allowed undefined output color
spaces.

Update some tests that were doing Rec601 YUV to RGB only to specify that
their output color space matches Rec601's primary and transfer function,
so that they'll continue to just do YUV to RGB (and so their images
won't need to be updated).

Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc363f5150398428dc31a7b59c35bb92b7d2a7d4
Reviewed-on: https://chromium-review.googlesource.com/656759
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500679}
[modify] https://crrev.com/da2054618ba98c20808fd3fcf0b6430426a51fcc/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/da2054618ba98c20808fd3fcf0b6430426a51fcc/cc/quads/render_pass.cc
[modify] https://crrev.com/da2054618ba98c20808fd3fcf0b6430426a51fcc/cc/quads/render_pass.h
[modify] https://crrev.com/da2054618ba98c20808fd3fcf0b6430426a51fcc/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/da2054618ba98c20808fd3fcf0b6430426a51fcc/components/viz/service/display/gl_renderer_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c24c8b62d042a978cb4656c4a2811f145bacb760

commit c24c8b62d042a978cb4656c4a2811f145bacb760
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sat Sep 16 05:10:35 2017

Remove color correct rendering flag from blink

This feature is now always-on, and the extra options are confusing.

TBR=junov

Bug:  759215 
Change-Id: I3bc81c92e83fe7bb3781ffa817d614917b43d364
Reviewed-on: https://chromium-review.googlesource.com/669219
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502488}
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/DragImage.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/CanvasColorParams.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/CanvasColorParams.h
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/ColorCorrectionTestUtils.h
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/mac/GraphicsContextCanvas.mm
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/c24c8b62d042a978cb4656c4a2811f145bacb760/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3569f27a3dfcd35eed77511381facc2758145342

commit 3569f27a3dfcd35eed77511381facc2758145342
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sun Sep 17 03:04:26 2017

Remove global target color space from Blink

In color correct rendering mode, the global target color space is always
set to sRGB. Change all callers that request this mode to instead
request a transform to sRGB.

R=dcheng, junov
TBR=avi (for content/)

Bug:  759215 
Change-Id: I4d3c47e0bb2b2ce1d8315013dc0da9329e47aaf0
Reviewed-on: https://chromium-review.googlesource.com/669395
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502521}
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/content/common/renderer.mojom
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/core/exported/WebImageDecoder.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/PngFuzzer.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/ColorBehavior.h
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
[modify] https://crrev.com/3569f27a3dfcd35eed77511381facc2758145342/third_party/WebKit/public/web/WebView.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac

commit e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sat Sep 23 01:15:27 2017

Update accessors to CanvasColorParams

Now that there is no more flag to disable color correct rendering,
simplify some of the accessors to CanvasColorParams. In particular,

Change
  UsesOutputSpaceBlending(), ColorCorrectNoColorSpaceToSRGB(), and
  LinearPixelMath()
to
  linear_pixel_math() (or its negation)
which for now returns true for non-legacy canvases. The next
patch in this sequence will plumb the linear pixel math parameter
from creation attributes to CanvasColorParams, and use that
appropriately.

Change
  ColorCorrectRenderingInSRGBOnly() and
  ColorCorrectRenderingInAnyColorSpace()
to
  !RuntimeEnabledFeatures::ColorCanvasExtensionsEnabled() and
  RuntimeEnabledFeatures::ColorCanvasExtensionsEnabled()
since they no longer depend on the color correct rendering flag.
A follow-on patch will replace this flag with experimental
canvas features.

Split GetGfxColorSpace into two functions -- one for storage,
and one for samplers, depending on which is needed by the caller.

Bug:  759215 
Change-Id: I72f3d0349bc34dae8e9fb0069eec7550a8fa95c9
Reviewed-on: https://chromium-review.googlesource.com/677096
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503923}
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorspace-arguments.html
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/CanvasColorParams.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/CanvasColorParams.h
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/CanvasColorParamsTest.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/e2b6cf4316da9928cdc895cd2d1d3bfb9d1029ac/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f214ec236bb904b61bac8ccddea7ac77ae013f2

commit 1f214ec236bb904b61bac8ccddea7ac77ae013f2
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Oct 03 16:20:32 2017

Remove color correct rendering flag

This is always on now

R=dcheng (ipc)
TBR=hubbe

Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5fa39ba61eae96658fed55a3b38d102a163ebd08
Reviewed-on: https://chromium-review.googlesource.com/695907
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506061}
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/display_resource_provider.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/resource_provider.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/resource_provider.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/test/fake_resource_provider.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/test/pixel_test.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/chrome/browser/about_flags.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/common/display/renderer_settings.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/host/renderer_settings_creation.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/service/display/display.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/public/common/web_preferences.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/content/test/layouttest_support.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/services/viz/privileged/interfaces/compositing/renderer_settings.mojom
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/services/viz/privileged/interfaces/struct_traits_unittest.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/compositor/compositor.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/gfx/BUILD.gn
[delete] https://crrev.com/8e24d103b035c2a369c260b02ff47a9d3c77f554/ui/gfx/color_space_switches.cc
[delete] https://crrev.com/8e24d103b035c2a369c260b02ff47a9d3c77f554/ui/gfx/color_space_switches.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/gfx/icc_profile.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/gfx/icc_profile.h
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/gfx/icc_profile_mac.mm
[delete] https://crrev.com/8e24d103b035c2a369c260b02ff47a9d3c77f554/ui/gfx/icc_profile_win.cc
[delete] https://crrev.com/8e24d103b035c2a369c260b02ff47a9d3c77f554/ui/gfx/icc_profile_x11.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/1f214ec236bb904b61bac8ccddea7ac77ae013f2/ui/views/widget/desktop_aura/desktop_screen_x11.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ece1d53abb013695f6c2148e9b7384e6dfd35fb

commit 8ece1d53abb013695f6c2148e9b7384e6dfd35fb
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Oct 03 16:40:37 2017

Revert "Remove color correct rendering flag"

This reverts commit 1f214ec236bb904b61bac8ccddea7ac77ae013f2.

Reason for revert:
Causing compile error:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/33582

Original change's description:
> Remove color correct rendering flag
> 
> This is always on now
> 
> R=​dcheng (ipc)
> TBR=hubbe
> 
> Bug:  759215 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I5fa39ba61eae96658fed55a3b38d102a163ebd08
> Reviewed-on: https://chromium-review.googlesource.com/695907
> Commit-Queue: ccameron chromium <ccameron@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506061}

TBR=dcheng@chromium.org,ccameron@chromium.org

Change-Id: I8c63b06cc535a95e55e1c7abad3898c050c6db1a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/698285
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506068}
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/display_resource_provider.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/resource_provider.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/resource_provider.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/test/fake_resource_provider.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/test/pixel_test.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/chrome/browser/about_flags.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/common/display/renderer_settings.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/host/renderer_settings_creation.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/service/display/display.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/public/common/web_preferences.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/content/test/layouttest_support.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/services/viz/privileged/interfaces/compositing/renderer_settings.mojom
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/services/viz/privileged/interfaces/struct_traits_unittest.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/compositor/compositor.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/BUILD.gn
[add] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/color_space_switches.cc
[add] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/color_space_switches.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/icc_profile.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/icc_profile.h
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/icc_profile_mac.mm
[add] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/icc_profile_win.cc
[add] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/icc_profile_x11.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/8ece1d53abb013695f6c2148e9b7384e6dfd35fb/ui/views/widget/desktop_aura/desktop_screen_x11.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b18507453f5b27f871d1f72e7d96d88ec2f82711

commit b18507453f5b27f871d1f72e7d96d88ec2f82711
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Oct 03 16:47:34 2017

Revert "Remove color correct rendering flag"

This reverts commit 1f214ec236bb904b61bac8ccddea7ac77ae013f2.

Reason for revert: cause compile failure on WebKit Linux Trusty 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/33582

Original change's description:
> Remove color correct rendering flag
> 
> This is always on now
> 
> R=​dcheng (ipc)
> TBR=hubbe
> 
> Bug:  759215 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I5fa39ba61eae96658fed55a3b38d102a163ebd08
> Reviewed-on: https://chromium-review.googlesource.com/695907
> Commit-Queue: ccameron chromium <ccameron@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506061}

TBR=dcheng@chromium.org,ccameron@chromium.org

Change-Id: Ic88157261a424cde09f76d65de3b37b349dc6dc6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/698286
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#506069}

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37d04fbcd60e2b8769bcaaab89f131f6f84a440b

commit 37d04fbcd60e2b8769bcaaab89f131f6f84a440b
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Oct 03 17:09:47 2017

Revert "Remove color correct rendering flag"

This reverts commit 1f214ec236bb904b61bac8ccddea7ac77ae013f2.

Reason for revert:
pixel_test.cc:183:17: error: no member named 'enable_color_correct_rasterization' in 'cc::LayerTreeSettings';

Original change's description:
> Remove color correct rendering flag
> 
> This is always on now
> 
> R=​dcheng (ipc)
> TBR=hubbe
> 
> Bug:  759215 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I5fa39ba61eae96658fed55a3b38d102a163ebd08
> Reviewed-on: https://chromium-review.googlesource.com/695907
> Commit-Queue: ccameron chromium <ccameron@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506061}

TBR=dcheng@chromium.org,ccameron@chromium.org

Change-Id: Ie745959545b3fbbaf686a941f49ce945b2eafe9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/698289
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506082}

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/325676c410c35f459594b8f8e415988fe92e0009

commit 325676c410c35f459594b8f8e415988fe92e0009
Author: Christopher Cameron <ccameron@chromium.org>
Date: Wed Oct 04 00:28:51 2017

Remove color correct rendering flag

This is always on now.

Previously landed as r506061, but hit mid-air collision.

R=dcheng (ipc)
TBR=hubbe

Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0bc5382571cb1d0e51eacaad4d5448c0b5864c1c
Reviewed-on: https://chromium-review.googlesource.com/698347
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506241}
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/display_resource_provider.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/display_resource_provider.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/layer_tree_resource_provider.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/layer_tree_resource_provider.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/resource_provider.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/resource_provider.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/test/fake_resource_provider.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/test/pixel_test.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/chrome/browser/about_flags.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/common/display/renderer_settings.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/host/renderer_settings_creation.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/service/display/display.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/public/common/web_preferences.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/content/test/layouttest_support.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/services/viz/privileged/interfaces/compositing/renderer_settings.mojom
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/services/viz/privileged/interfaces/compositing/renderer_settings_struct_traits.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/services/viz/privileged/interfaces/struct_traits_unittest.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/compositor/compositor.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/display/mac/screen_mac.mm
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/gfx/BUILD.gn
[delete] https://crrev.com/bd107a7eafad8a1e638a085c1779151160236a76/ui/gfx/color_space_switches.cc
[delete] https://crrev.com/bd107a7eafad8a1e638a085c1779151160236a76/ui/gfx/color_space_switches.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/gfx/icc_profile.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/gfx/icc_profile.h
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/gfx/icc_profile_mac.mm
[delete] https://crrev.com/bd107a7eafad8a1e638a085c1779151160236a76/ui/gfx/icc_profile_win.cc
[delete] https://crrev.com/bd107a7eafad8a1e638a085c1779151160236a76/ui/gfx/icc_profile_x11.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/gfx/mac/io_surface.cc
[modify] https://crrev.com/325676c410c35f459594b8f8e415988fe92e0009/ui/views/widget/desktop_aura/desktop_screen_x11.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ffdd9ed12cffe500a698c8af6f7b13e884327b

commit e8ffdd9ed12cffe500a698c8af6f7b13e884327b
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Oct 23 20:13:44 2017

Remove CanvasColorFeatures flag

Change this to be behind ExperimentalCanvasFeatures.

Change the default values to "legacy" so that this does
not change default canvas behavior.

R=junov
TBR=jbroman (v8/serialization)

Bug:  759215 
Change-Id: I3b7e8616881f4c2fac3ff50731d39c1bbb6da491
Reviewed-on: https://chromium-review.googlesource.com/724819
Commit-Queue: ccameron (ping after 24hr) <ccameron@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510892}
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/LayoutTests/fast/canvas/color-space/ImageData-fidelity.html
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/imageData-colorSpace.html
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/html/ImageDataColorSettings.idl
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/html/ImageDataTest.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/CanvasColorParamsTest.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/ColorCorrectionTestUtils.h
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/e8ffdd9ed12cffe500a698c8af6f7b13e884327b/third_party/WebKit/Source/platform/testing/RuntimeEnabledFeaturesTestHelpers.h

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d06761bccd6a06fd114298646cec6360b5b1995

commit 2d06761bccd6a06fd114298646cec6360b5b1995
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Nov 21 21:15:39 2017

Remove YUVVideoDrawQuad::ColorSpace

This is no longer read by GLRenderer -- it's just plumbed to nowhere.

Bug:  759215 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0667217d643c3e527947106ff1de48e04d935f0f
Reviewed-on: https://chromium-review.googlesource.com/780147
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518396}
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/cc/ipc/cc_param_traits_unittest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/common/quads/yuv_video_draw_quad.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/common/quads/yuv_video_draw_quad.h
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/2d06761bccd6a06fd114298646cec6360b5b1995/services/viz/public/interfaces/compositing/quads.mojom

Status: Fixed (was: Assigned)
I think all of this code is gone.

Sign in to add a comment