WebApkInstaller::InstallOrUpdateWebApk() crashes during updates |
|||
Issue descriptionWebApkInstaller::InstallOrUpdateWebApk() crashes during updates Stack trace (from tombstones) base::debug::BreakDebugger()+21 /usr/local/google/home/pkotwicz/clankium3/src/base/debug/debugger_posix.cc:258 logging::LogMessage::~LogMessage()+669 /usr/local/google/home/pkotwicz/clankium3/src/base/logging.cc:791 gfx::ConvertToJavaBitmap(SkBitmap const*)+75 /usr/local/google/home/pkotwicz/clankium3/src/ui/gfx/android/java_bitmap.cc:71 WebApkInstaller::InstallOrUpdateWebApk(std::__ndk1::basic_string<ch ar, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, int, std::__ndk1::basi c_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&)+125 /usr/local/google/home/pkotwicz/clankium3/src/chrome/browser/android/webapk/webapk_installer.cc:293 42 I 34.818s Main 005e66af WebApkInstaller::OnURLFetchComplete(net::URLFetcher const*)+ /usr/local/google/home/pkotwicz/clankium3/src/chrome/browser/android/webapk/webapk_installer.cc:426
,
Aug 28 2017
This was a really frustrating crash over the weekend and second highest browser crash. As a follow-up can we add some sort of testing for update flow?
,
Aug 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9705d4d3adbaeafde118dcee7848233e272c2d91 commit 9705d4d3adbaeafde118dcee7848233e272c2d91 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Aug 28 14:59:28 2017 Fix crash in WebApkInstaller::InstallOrUpdateWebApk() The crash was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/602750/ WebApkInstaller::install_primary_icon_ is only initialized in the install path BUG= 759212 ,755636 Change-Id: Ia3054b929ece122539d98ae0b9adc09533ff2f76 Reviewed-on: https://chromium-review.googlesource.com/636664 Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#497761} [modify] https://crrev.com/9705d4d3adbaeafde118dcee7848233e272c2d91/chrome/browser/android/webapk/webapk_installer.cc
,
Aug 29 2017
I've hit this consistently in my daily usage of the Twitter Lite PWA. It is very annoying, since it is hit on every switch away from it, killing any state you might have. Let me know if you need more data I can help with.
,
Sep 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hanxi@chromium.org
, Aug 28 2017