New issue
Advanced search Search tips

Issue 759210 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature



Sign in to add a comment

Document the transport security state generator and the preload format.

Project Member Reported by mart...@martijnc.be, Aug 25 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.39 Safari/537.36

Steps to reproduce the problem:
The transport security state generator (net/tools/transport_security_state_generator) generates a data structure that contains the domain security state (currently HSTS, HPKP, Expect-CT, and Expect-Staple) for the preloaded entries. This structure is compiled into the Chrome binary.

The binary format for this structure has evolved over the years and only parts of it are documented.

Creating a README file that centralizes and extends the current documentation will help developers and reviewers understand this part of the code more quickly.

What is the expected behavior?

What went wrong?

Did this work before? No 

Chrome version: 61.0.3163.39  Channel: n/a
OS Version: OS X 10.12.5
Flash Version: 

Please move this to the Internals>Network>DomainSecurityPolicy component.
 

Comment 1 by tapted@chromium.org, Aug 28 2017

Components: Internals>Network

Comment 2 by tapted@chromium.org, Aug 28 2017

Components: -Internals>Network Internals>Network>DomainSecurityPolicy
Cc: rbasuvula@chromium.org
Labels: Needs-Triage-M61
Status: Untriaged (was: Unconfirmed)
Considering this as a feature request and making the status to Untriaged so that the issue would get addressed.

Thank you.
Status: Available (was: Untriaged)

Comment 5 by mart...@martijnc.be, Aug 30 2017

I've started writing documentation for this (but can't assign this bug to myself).
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/413d7502992c9316ab84e63ec4be053af78fcb0d

commit 413d7502992c9316ab84e63ec4be053af78fcb0d
Author: Martijn Croonen <martijn@martijnc.be>
Date: Sun Sep 24 16:41:08 2017

Add transport security state generator and preload format documentation.

Bug:  759210 
Change-Id: Icca4100d75f0a2c3e6a9fe716524c159815ddf1d
Reviewed-on: https://chromium-review.googlesource.com/649527
Commit-Queue: Martijn Croonen <martijn@martijnc.be>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503957}
[add] https://crrev.com/413d7502992c9316ab84e63ec4be053af78fcb0d/net/tools/transport_security_state_generator/README.md

Labels: M-63
Status: Fixed (was: Available)
Thanks!

Sign in to add a comment