New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759196 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 753158
issue 759774



Sign in to add a comment

Implement Rules for auditing findit's auto-commit

Project Member Reported by robert...@chromium.org, Aug 25 2017 
From the design doc:

'culprit_age': Make sure that the culprit's committer_date is less than 24 hours away from the revert's committer_date. (Add a 10 minute tolerance to account for CQ times, etc.)

'culprit_in_build': Make sure that the culprit hash is included in the list of changes for the failed build.

'build_failed': Make sure that the example build has a failure matching the failures noted in the revert description (This requires a Findit-side change to note these failures in the body of the revert commit description). i.e. traverse the 'steps' field of the milo response, look for one named 'compile' (or as appropriate) and examine its 'results' key.


'daily_auto_commit_limit_for_compile_failures': Query the datastore for commits in the last 24 hours, make sure that at most 4 of them have the committer_email set to findit-for-me@appspot.gserviceaccount.com

'daily_auto_revert_limit_for_compile_failures': Query the datastore for commits in the last 24 hours, make sure that at most 10 of them have the author_email set to findit-for-me@appspot.gserviceaccount.com

Comment 1 by robert...@chromium.org, Aug 28 2017

Blocking: 759774
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f3d06c0631ef334d7ce316c4406ded275bba471e

commit f3d06c0631ef334d7ce316c4406ded275bba471e
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 08 20:23:29 2017

[cr-audit-commits] Rule to check failed build contains culprit.

This rule checks that the sample failed build referenced in the commit
message of the revert contains among its changes the revision being
reverted.

R=stgao,chanli,iannucci,agable
Bug:759196
Change-Id: Idadb58356be1434c1850032df35ee0e89437ccce
Reviewed-on: https://chromium-review.googlesource.com/650466
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/test_utils.go
[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/rules_config.go
[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go
[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go
[modify] https://crrev.com/f3d06c0631ef334d7ce316c4406ded275bba471e/go/src/infra/appengine/cr-audit-commits/app/utils.go
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e3ad4ddcc78dc0023cb4bc6972407961af03bd73

commit e3ad4ddcc78dc0023cb4bc6972407961af03bd73
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 08 23:23:45 2017

[cr-audit-commits] Rule to check that failed build is compile failure.

This rule verifies that the build referred by the revert's message is
actually a failed compile.

R=chanli,stgao,agable,iannucci
Bug:759196
Change-Id: I5b6a39117b6ba218117adc0a02cea4f0c3d05d36
Reviewed-on: https://chromium-review.googlesource.com/651581
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/e3ad4ddcc78dc0023cb4bc6972407961af03bd73/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/e3ad4ddcc78dc0023cb4bc6972407961af03bd73/go/src/infra/appengine/cr-audit-commits/app/utils.go
[modify] https://crrev.com/e3ad4ddcc78dc0023cb4bc6972407961af03bd73/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/45c04e10065e95223c95ab0c914405dec943990a

commit 45c04e10065e95223c95ab0c914405dec943990a
Author: Roberto Carrillo <robertocn@google.com>
Date: Sat Sep 09 00:01:05 2017

[cr-audit-commits] Rule to check that commit is revert of culprit.

This rule verifies that the commit being audited is (according to
Gerrit) a clean revert of the culprit mentioned in the commit message of
the revert.

R=stgao,chanli,agable,iannucci
BUG= 759196 

Change-Id: I913260d7bd82a170f1fc13c795026b31c1855d09
Reviewed-on: https://chromium-review.googlesource.com/651754
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/45c04e10065e95223c95ab0c914405dec943990a/go/src/infra/appengine/cr-audit-commits/app/rules_config.go
[modify] https://crrev.com/45c04e10065e95223c95ab0c914405dec943990a/go/src/infra/appengine/cr-audit-commits/app/findit_rules_test.go
[modify] https://crrev.com/45c04e10065e95223c95ab0c914405dec943990a/go/src/infra/appengine/cr-audit-commits/app/model.go
[modify] https://crrev.com/45c04e10065e95223c95ab0c914405dec943990a/go/src/infra/appengine/cr-audit-commits/app/findit_rules.go

Comment 7 by robert...@chromium.org, Sep 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment