New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759190 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 678288



Sign in to add a comment

Change WebView Variations Services to use AIDL instead of Messengers

Project Member Reported by kmilka@google.com, Aug 25 2017

Issue description

Currently the AwVariationsSeedHandler, AwVariationsConfigurationService, and AwVariationsSeedFetchService use Messengers for IPC. It's been discussed that we use AIDL instead. Here's a brief summary of the main points.

AIDL:

-Overall easier to read / understand.
-Easy to verify that the message received by AwVariationsConfigurationService actually originated from AwVariationsSeedFetchService.

Messengers:

-All messages arrive on the same handler thread, eliminating the need for locking.
 
If we want this to be running on a single thread even when using AIDL can't we just call something like postOnWorkerThreadBlocking() ?

Comment 2 by boliu@chromium.org, Sep 11 2017

err, no blocking, but yes, need to just post everything to the main thread

binder messages are synchronous by default, and the way binder handles synchronous call cycles is uhh... somewhat unexpected
Well, we will want to return seed if it's fresh - in that case we will either have to block or use a lock to fetch the seed I think?

Comment 4 by boliu@chromium.org, Sep 11 2017

oh yeah, probably judicious use of lock then

Comment 5 by sgu...@chromium.org, Sep 27 2017

Cc: -sgu...@chromium.org

Comment 6 by kmilka@chromium.org, May 26 2018

Cc: -kmilka@google.com
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Status: Fixed (was: Assigned)
This was implemented in https://crrev.com/c/954058 and https://crrev.com/c/1036852.

Sign in to add a comment