New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759187 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

crostestutils: cros lint should not enforce cros_logging usage

Project Member Reported by semenzato@chromium.org, Aug 25 2017

Issue description

When uploading a CL for src/platform/crostestutils/recover_duts/recover_duts.py, I was told that I should replace "import logging" with "from chromite.lib import cros_logging as logging".  But I was warned by a reviewer that this may not work on a DUT (this script runs on DUTs) and in fact a test image does not appear to contain chromite.lib.

If this advice is generally useful by all means keep it, but you may want to qualify it with "if the python environment supports it, use...".  I understand one will still have to skip the hooks to upload.
 

Comment 1 Deleted

Comment 2 Deleted

Sign in to add a comment