[WPT Export] Exporter exports Chromium OWNERS changes from Gerrit CLs |
|||||
Issue descriptionExporter tries (and already succeeded in one case) to export Chromium OWNERS to upstream GitHub. Note that this only happens when PR is created from Gerrit in-flight CLs. (i.e. PRs created from Chromium commits would not contain OWNERS files.) As mentioned in issue 734799 , there are multiple copies of logics for deciding whether a file needs to be synced or not. And unfortunately, they are not the same, although they should. When implementing issue 713987 , we only checked some of these tests and thought they already excluded OWNERS. However, the test in GerritCL was missed, and OWNERS changes are not filtered there. Fortunately, there is only one accidentally exported OWNERS thus far: https://github.com/w3c/web-platform-tests/commit/29c754d19d31b6c8f1c60c6da3204e78a7273d86 (because the batch conversion in issue 713987 was too large and automatically skipped by the exporter) P.S. the decision of not syncing OWNERS was made in issue 702283 .
,
Aug 25 2017
I've created a PR to remove the accidental export: https://github.com/w3c/web-platform-tests/pull/7017 I just checked the code and can confirm that only OWNERS files newly created in Chromium after the aforementioned batch conversion will be exported; modifications won't, since the patches would not apply. Downgrading to P1, as there won't be large-scale spill of OWNERS files into upstream which I was worried about. And I will keep an eye on export PRs while fixing the bug.
,
Aug 28 2017
,
Aug 28 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca53e37a8293d6575444a72f477c1643c9c24ea commit 0ca53e37a8293d6575444a72f477c1643c9c24ea Author: Robert Ma <robertma@chromium.org> Date: Thu Aug 31 20:27:09 2017 Extract all filename testing/filtering routines into common.py for reuse There were similar routines for checking whether a file is exportable based on its name (or path) all over the codebase. Some of them were slightly different, which caused intricate issues like 759181. This change extracts all of them into one central place (w3c/common.py) so that they can be reused. Bug: 734799 , 759181 Change-Id: Ie54e2f455c046383f1aaab2670596ffdf24128b7 Reviewed-on: https://chromium-review.googlesource.com/643760 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#498977} [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_exportable_commits_unittest.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py [modify] https://crrev.com/0ca53e37a8293d6575444a72f477c1643c9c24ea/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py
,
Aug 31 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by robertma@chromium.org
, Aug 25 2017