New issue
Advanced search Search tips

Issue 759177 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Harmony - default stroke for dropdown and text input box should be the same as the default button stroke

Project Member Reported by hwi@chromium.org, Aug 25 2017

Issue description

*Dropdown* and *text input box* should have the same border opacity color as the recent fix on the default button stroke ( bug 660414 ). 

Currently they're lighter than the latest button stroke opacity color. 

bettes@ - is matching the opacity SGTY?
 
stroke.png
72.3 KB View Download
Labels: -Pri-2 Pri-1
Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)
I agree these should stay in sync.
Changed the opacity of the dropdown stroke to match the button stroke. Note this will affect all "unfocused border colors" which use the kColorId_UnfocusedBorderColor color id.

Was 000000 @ 0.2 alpha, now 000000 @ 0.3 alpha.
DropDownStrokeColor.png
3.0 KB View Download

Comment 3 by hwi@chromium.org, Aug 31 2017

Thanks kylixrd@! 

ᕕ( ᐛ )ᕗ   \(^O^)/
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17d074db93a158528881ea2e3a5212ce3b741cb1

commit 17d074db93a158528881ea2e3a5212ce3b741cb1
Author: Allen Bauer <kylixrd@chromium.org>
Date: Thu Aug 31 18:21:17 2017

Changed kColorId_UnfocusedBorderColor under MD from 000000 @ 0.2a to 000000 @ 0.3a.

TBR=pkasting@chromium.org

Bug:  759177 
Change-Id: I3390e51af56ac00622d7145f40946d8e23e728b0
Reviewed-on: https://chromium-review.googlesource.com/644066
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498923}
[modify] https://crrev.com/17d074db93a158528881ea2e3a5212ce3b741cb1/ui/native_theme/common_theme.cc

Status: Fixed (was: Assigned)

Sign in to add a comment