New issue
Advanced search Search tips

Issue 759176 link

Starred by 1 user
Status: Fixed
Owner:
etienneb@chromium.org
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: ----



Sign in to add a comment

ProfilingJsonExporterTest.Simple is failing on chromium.linux/Linux Tests (dbg)(1)

Project Member Reported by zea@chromium.org, Aug 25 2017 
unit_tests failing on chromium.linux/Linux Tests (dbg)(1)

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29


[ RUN      ] ProfilingJsonExporterTest.Simple
../../chrome/profiling/json_exporter_unittest.cc:156: Failure
Value of: IsBacktraceInList(nodes, 2, 0)
  Actual: false
Expected: true
../../chrome/profiling/json_exporter_unittest.cc:157: Failure
Value of: IsBacktraceInList(nodes, 3, 2)
  Actual: false
Expected: true
[  FAILED  ] ProfilingJsonExporterTest.Simple (1 ms)

No obvious culprits yet, if I can't find one I'll disable.

Comment 1 by zea@chromium.org, Aug 25 2017

Components: Platform>DevTools>Memory
Labels: Pri-2
Owner: etienneb@chromium.org
Status: Assigned (was: Available)
Tests started failing @ 	021236f9262576b52303809d9d5468c100554fee

Three failures in a row now, disabling.

Etienne, looks like you last touched this file. Could you take a look?

Comment 2 by etienneb@google.com, Aug 25 2017 

The CL fixing the bug didn't landed yet, but is ready.
I'm gonna turn on the test later.

Comment 3 by zea@chromium.org, Aug 25 2017 

Looks like this fails on Windows too. Disabling on all platforms.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/657cc976ba1f41c63248d3e6eb39ff7e4883b902

commit 657cc976ba1f41c63248d3e6eb39ff7e4883b902
Author: Nicolas Zea <zea@chromium.org>
Date: Fri Aug 25 22:23:59 2017

Disable ProfilingJsonExporterTest.Simple on Linux

Bug:  759176 
Change-Id: Ifd90f3304a6a7eedce7dde58c9f61da8d92372f2
TBR: etienneb@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/636206
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497562}
[modify] https://crrev.com/657cc976ba1f41c63248d3e6eb39ff7e4883b902/chrome/profiling/json_exporter_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e7d02732a7cd72c743583ab8890c581f2f86eb

commit e9e7d02732a7cd72c743583ab8890c581f2f86eb
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Mon Aug 28 16:39:59 2017

Fix a flaky JSonExporter unittest and enhance test coverage

The test was flaky because the order of element in a map is not defined.

The CL is also adding more validation of the resulting JSON file.

R=erikcheng@chromium.org, brettw@chromium.org

Bug:  759176 
Change-Id: I6305aea25abccce674d9939c1fa966a917148a99
Reviewed-on: https://chromium-review.googlesource.com/636351
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497777}
[modify] https://crrev.com/e9e7d02732a7cd72c743583ab8890c581f2f86eb/chrome/profiling/json_exporter_unittest.cc

Comment 8 by etienneb@chromium.org, Aug 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment