New issue
Advanced search Search tips

Issue 759167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task


Show other hotlists

Hotlists containing this issue:
Payments-Dedupe


Sign in to add a comment

Move payment_request.h from web to components

Project Member Reported by mahmadi@chromium.org, Aug 25 2017

Issue description

Web layer is not suppose to depend on components.

Move ios/web/public/payments/payment_request.h, ios/web/payments/payment_request.cc, and related tests to components.
 
Components: Mobile>WebView>Glue
Labels: -Type-Bug Type-Task
Components: UI>Browser>Payments
Adding this to the Dedupe hotlist; we would like not only to take care of this dependency, but also to reduce duplicate code. These classes roughly mirror code that we have in components/content for the Mojo implementations.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3da037a3bc1698447d472062e44ee36ce105e29

commit a3da037a3bc1698447d472062e44ee36ce105e29
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Oct 10 16:00:59 2017

[PR] Move PaymentRequest and rest of related classes from web to components

Bug:  759167 
Change-Id: I27fcee124c9c693dc12ee27a6af5477573e91b88
Reviewed-on: https://chromium-review.googlesource.com/701585
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507679}
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/BUILD.gn
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/basic_card_response.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_address.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_currency_amount.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_currency_amount.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_details.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_details_modifier.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_details_modifier_unittest.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_details_unittest.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_item.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_item_unittest.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_method_data.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_method_data_unittest.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_options.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_options.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_options_provider.h
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_options_unittest.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_response.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_response.h
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_response_unittest.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_shipping_option.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/payment_shipping_option_unittest.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/web_payment_request.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/web_payment_request.h
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/components/payments/core/web_payment_request_unittest.cc
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/app_startup_parameters.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/BUILD.gn
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/ios_payment_instrument_launcher.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/ios_payment_instrument_launcher_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request.mm
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_constants.cc
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_constants.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_test_util.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_util.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_util.mm
[add] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_request_util_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_response_helper.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_response_helper.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/payment_response_helper_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/test_payment_request.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/payments/test_payment_request.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/address_edit_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/address_edit_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/address_edit_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/billing_address_selection_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/billing_address_selection_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/billing_address_selection_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_edit_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_edit_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_selection_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_selection_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/contact_info_selection_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/credit_card_edit_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/credit_card_edit_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/js_payment_request_manager.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/js_payment_request_manager.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_items_display_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_items_display_coordinator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_items_display_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_items_display_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_method_selection_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_method_selection_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_method_selection_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_request_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_request_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_request_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/payment_request_mediator_unittest.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_address_selection_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_address_selection_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_address_selection_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.h
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/chrome/browser/ui/payments/shipping_option_selection_mediator.mm
[modify] https://crrev.com/a3da037a3bc1698447d472062e44ee36ce105e29/ios/web/BUILD.gn
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/payments/DEPS
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/payments/OWNERS
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/payments/payment_request.cc
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/payments/payment_request_unittest.cc
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/public/payments/DEPS
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/public/payments/OWNERS
[delete] https://crrev.com/98ca9f065e1bb7b266628e98cc35f5e14323299c/ios/web/public/payments/payment_request.h

Status: Fixed (was: Started)

Sign in to add a comment