New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759161 link

Starred by 2 users
Status: Fixed
Owner:
█ hamelphi@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
chrome-ranker@google.com
donnd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 776156



Sign in to add a comment

Implement Contextual Search Ranker Model

Project Member Reported by hamelphi@chromium.org, Aug 25 2017 
Providing a Ranker model for Contextual search will require:

- Adding a ContextualSearch model to RankerModel
- Implementing a generic logistic regression proto
- Implement inference for the generic LR
- Send features from Contextual search to Ranker for inference


Most of this code will live in src/components/machine_intelligence/

Comment 1 by donnd@google.com, Sep 1 2017

Components: UI>Browser>Search>ContextualSearch

Comment 2 by donnd@google.com, Oct 17 2017

Blocking: 727781

Comment 4 by donnd@google.com, Oct 18 2017

Blocking: 776156

Comment 5 by donnd@google.com, Oct 18 2017

Blocking: -727781
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d324d5db20e17fe456624dec5e918e0598b2ccba

commit d324d5db20e17fe456624dec5e918e0598b2ccba
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Thu Oct 19 20:09:51 2017

GenericLogisticRegressionInference

This CL depends on
https://chromium-review.googlesource.com/c/chromium/src/+/723589

Bug:  759161 
Change-Id: I8f4334b53a185fa4354d1e78e243c69a7e41a488
Reviewed-on: https://chromium-review.googlesource.com/724122
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510176}
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/BUILD.gn
[add] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/generic_logistic_regression_inference.cc
[add] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/generic_logistic_regression_inference.h
[add] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/generic_logistic_regression_inference_unittest.cc
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/BUILD.gn
[add] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/contextual_search_ranker_model.proto
[add] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/generic_logistic_regression_model.proto
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/ranker_example.proto
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/ranker_model.proto
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/proto/translate_ranker_model.proto
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/ranker_example_util.cc
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/ranker_example_util.h
[modify] https://crrev.com/d324d5db20e17fe456624dec5e918e0598b2ccba/components/machine_intelligence/ranker_example_util_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6cb5c835e12ffa75e26eaefeef631d125c4e04d

commit c6cb5c835e12ffa75e26eaefeef631d125c4e04d
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Wed Nov 01 18:41:59 2017

Fix GenericLogisticRegressionInference includes.

Bug:  759161 
Change-Id: I199c7604eb38fc5a1b8107710eeaa27f8e71b299
Reviewed-on: https://chromium-review.googlesource.com/743690
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513195}
[modify] https://crrev.com/c6cb5c835e12ffa75e26eaefeef631d125c4e04d/components/machine_intelligence/generic_logistic_regression_inference.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1386fbd7cb5cafb44a9cdbf38f0615435f8086

commit ab1386fbd7cb5cafb44a9cdbf38f0615435f8086
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Wed Nov 01 20:32:55 2017

Move generic model directly in the RankerModelProto.

Deleting CS Ranker Model. This change is not wire-compatible, but we have not published any CS models yet. So, this should not break anything.

Bug:  759161 
Change-Id: I43e6a2885a97ab030eb43edd01e44773e6239693
Reviewed-on: https://chromium-review.googlesource.com/732167
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513250}
[modify] https://crrev.com/ab1386fbd7cb5cafb44a9cdbf38f0615435f8086/components/machine_intelligence/proto/BUILD.gn
[delete] https://crrev.com/a1664ce01a2bdff5a237a0d92d432107789220dd/components/machine_intelligence/proto/contextual_search_ranker_model.proto
[modify] https://crrev.com/ab1386fbd7cb5cafb44a9cdbf38f0615435f8086/components/machine_intelligence/proto/ranker_model.proto
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/409d3e079518ba2d0f811bac0781885a11937d3f

commit 409d3e079518ba2d0f811bac0781885a11937d3f
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Tue Nov 07 22:55:14 2017

AssistRankerService.

This CL puts in place the first steps towards a generalized machine learning infrastructure.
See go/chrome-ranker for more details.

Bug:  759161 
Change-Id: I87ff523cc4b8edf0076226806acf6a131ee2f4d0
Reviewed-on: https://chromium-review.googlesource.com/729060
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514636}
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/chrome/browser/BUILD.gn
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/chrome/browser/assist_ranker/OWNERS
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/chrome/browser/assist_ranker/assist_ranker_service_factory.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/chrome/browser/assist_ranker/assist_ranker_service_factory.h
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/BUILD.gn
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/DEPS
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/assist_ranker_service.h
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/assist_ranker_service_impl.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/assist_ranker_service_impl.h
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/base_predictor.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/base_predictor.h
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/binary_classifier_predictor.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/binary_classifier_predictor.h
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/binary_classifier_predictor_unittest.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/fake_ranker_model_loader.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/fake_ranker_model_loader.h
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/generic_logistic_regression_inference.cc
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/generic_logistic_regression_inference.h
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/generic_logistic_regression_inference_unittest.cc
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/ranker_model_loader.h
[rename] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/ranker_model_loader_impl.cc
[add] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/ranker_model_loader_impl.h
[rename] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/machine_intelligence/ranker_model_loader_impl_unittest.cc
[modify] https://crrev.com/409d3e079518ba2d0f811bac0781885a11937d3f/components/translate/core/browser/translate_ranker_impl.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a50ec0d70fc000755b6f4d0ad4419a9223d25c7

commit 6a50ec0d70fc000755b6f4d0ad4419a9223d25c7
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Wed Dec 06 21:53:47 2017

Update Contextual Search Ranker test model.

Bug:  759161 
Change-Id: I81acfa8caf45d460ebfc940f8d182300623769e1
Reviewed-on: https://chromium-review.googlesource.com/811751
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522211}
[modify] https://crrev.com/6a50ec0d70fc000755b6f4d0ad4419a9223d25c7/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f72838b8e30b4ed4cec13d7d78fe3dadaafeaa

commit 68f72838b8e30b4ed4cec13d7d78fe3dadaafeaa
Author: Philippe Hamel <hamelphi@chromium.org>
Date: Tue Jan 09 00:21:00 2018

Add CS model loader histograms.

Bug:  759161 
Change-Id: I254c049071dbf25437dacbbe3552b06069180936
Reviewed-on: https://chromium-review.googlesource.com/853134
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527825}
[modify] https://crrev.com/68f72838b8e30b4ed4cec13d7d78fe3dadaafeaa/tools/metrics/histograms/histograms.xml

Comment 13 by hamelphi@chromium.org, Jan 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment