New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759152 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Overlay scrollbar has no search marker. Jumping to the keyword does not show the scrollbar.

Project Member Reported by osh...@chromium.org, Aug 25 2017

Issue description

on ToT:

Repro step:
1) go www.google.com and search "test"
2) ctrl-f and type "test"
3) hit enter

original (non overlay scrollbar) behavior.
 - at step 2, search markers are shown on the scrollbar
 - at step 3, the scroll bar moves to the position as the page scroll to the keyword position.

actual:
 none of above happens.

bokan@, do you know if this feature was removed or just oversight?

 

Comment 1 by osh...@chromium.org, Aug 25 2017

Labels: -Type-Bug Type-Bug-Regression

Comment 2 by bokan@chromium.org, Aug 25 2017

Labels: Hotlist-Input-Dev
Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)
I remember we specifically fixed this so it should work. Assigning to chaopeng@ to take a look.

Comment 3 by osh...@chromium.org, Aug 25 2017

Summary: Overlay scrollbar has no search marker. Jumping to the keyword does not show the scrollbar. (was: Overlay scrollbar has no search marker. Jumping to the keyward does not show the scrollbar.)
Just test on latest code.

1. marker does not show.
2. keyword jump with scroll offset change will appear scrollbar.
TickMarks for Overlay Scrollbar was added  crbug.com/661392 . That patch used ScrollbarTheme::Paint to Paint TickMarks.

In e7a058aa7db4c0fc172200fd16c800ec1b94d8e6 "Use nine-patch resource for drawing Aura overlay scrollbar thumb" change Overlay Scrollbar paint to painted_overlay_scrollbar_layer and only call PaintThumb.

We also need to add PaintTickMarks in this case. I still have something not very clear for using painted_overlay_scrollbar_layer will fix after bokan come back.

Comment 6 by bokan@chromium.org, Sep 5 2017

Labels: -Pri-3 M-62 OS-Chrome Pri-1
Bumping priority since this is a regression. The fix should be simple so we can probably get it merged into M62.
#4, the scrollbar does not seem to show on the first scroll. It also shows only when page jumps, which may not be convenient when exploring.

https://drive.google.com/a/google.com/file/d/0Bx_xtqaB0-v0ZFJveDBVbHplUm8/view?usp=sharing

This is ToT as of last Friday.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6903e859e9fa6a8e1ea22680dd36e84868945fa6

commit 6903e859e9fa6a8e1ea22680dd36e84868945fa6
Author: chaopeng <chaopeng@chromium.org>
Date: Thu Mar 01 21:04:35 2018

Tickmarks for Aura Overlay Scrollbars

Currently Aura Overlay Scrollbar paints in PaintedOverlayScrollbarLayer which
only paint the thumb part. In this patch, we paint the tickmarks when
we have tickmarks in scrollbar when PaintedOverlayScrollbarLayer update.

Bug:  759152 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I9e351b475cd9afa14cdae9264a2b78ab36a18258
Reviewed-on: https://chromium-review.googlesource.com/641611
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540284}
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/BUILD.gn
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/blink/scrollbar_impl.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/blink/scrollbar_impl.h
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/input/scrollbar.h
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/layers/painted_overlay_scrollbar_layer.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/layers/painted_overlay_scrollbar_layer.h
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/layers/painted_overlay_scrollbar_layer_impl.h
[add] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/layers/painted_overlay_scrollbar_layer_unittest.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/test/fake_scrollbar.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/test/fake_scrollbar.h
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/cc/trees/layer_tree_host_pixeltest_scrollbars.cc
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.cpp
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h
[modify] https://crrev.com/6903e859e9fa6a8e1ea22680dd36e84868945fa6/third_party/WebKit/public/platform/WebScrollbar.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f96bf98424361868944d3a4594b2d9c63f544546

commit f96bf98424361868944d3a4594b2d9c63f544546
Author: chaopeng <chaopeng@chromium.org>
Date: Fri Mar 09 23:45:37 2018

Prevent Aura Overlay Scrollbar fade out when tickmarks show

Currently, Aura Overlay Scrollbar will fade out when user finding in the
page. This patch is to improve this UX.

In this patch, we check HasFindInPageTickmarks in root vertical Scrollbar Layer
then show and prevent it fadeout or post the hide animation the scrollbar at the
end of syncing pending tree to active tree.

After this, we will show Aura Overlay Scrollbar when user type the first
character in find in page box and post fade out animation when user
close find in page or delete last character in find in page box.

Bug:  759152 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id2baf95a6441ffa58a09597dba6b0bed5299a1c3
Reviewed-on: https://chromium-review.googlesource.com/946744
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542281}
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/layers/painted_overlay_scrollbar_layer_impl.cc
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/layers/painted_overlay_scrollbar_layer_impl.h
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/layers/scrollbar_layer_impl_base.cc
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/layers/scrollbar_layer_impl_base.h
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/f96bf98424361868944d3a4594b2d9c63f544546/cc/trees/layer_tree_impl.h

Comment 10 by bokan@chromium.org, Mar 22 2018

Status: Fixed (was: Assigned)
Fix confirmed in Dev channel.

Sign in to add a comment